Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts pushed 1 commit to keyword-field ProfessionalWiki/WikibaseFacetedSearch
- Add aggregatable index field f13073c
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add aggregatable index field
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/23#issuecomment-2567096737 All fields are now aggregatable: 
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
keyword-field - Enhanced searching interface with drilldown for Wikibase
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Both, those are different things: instanceOfId is coming from config and is a property ID itemType is coming from the query string and is the value an item needs to have for the instanceOfId ...
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add input validation for range facet
#118 Key changes: - Invalidate input when minimum is greater than maximum, or vise-versa - Disable apply button when input is invalidated - Show error state when input is invalidated - Upda...
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I decided to greatly simplify this and remove YAGNI stuff. Some of the original code in this PR was based on the old code that tried to rewrite Item links in a way that was consistent with how Item...
malberts pushed 1 commit to search-title ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite 77c7f69
malberts pushed 3 commits to search-title ProfessionalWiki/WikibaseFacetedSearch
alistair3149 pushed 1 commit to feat-118 ProfessionalWiki/WikibaseFacetedSearch
- Use boolean check directly 3160999
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
In that case, should we use `instanceOfId` or should we use `itemType`?
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Did not know that, will update it tomorrow
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
After this test is adjusted to provide `PropertyId $instanceOfId` to `new QueryStringParser`, some additional tests will be in order: * testItemTypeIsNullWhenNotPresent * testIgnoresHaswbstatem...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Btw, the existing return type confused me for a while. First I wondered "why is this an array" and then I thought "because an item can have multiple types". But no, it's an array because you return...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Parameter and return types should change to `ItemId[]`
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`$instance` should not be by-reference Name isn't great. What about `itemTypes`?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I think the prior naming `itemType` is more appropriate as it matches the domain language
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We need a new constructor argument: `private readonly PropertyId $instanceOfId` Then in here we need to only match `'haswbstatement:' . $this->instanceOfId->getSerialization()`