Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/Bootstrap
- Update author name in extension.json caa95f7
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
@malberts is this done?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
That separates concerns better Also makes so existing tests can stay focused on building of the checkbox view model, without having to care about the new logic.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Looks like you can return the method to its original form (returning just $checkboxes) and then have the caller (perhaps a new method) do ```php return [ 'visible' => array_slice_or_something_...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I see many existing tests got new entries and no new ones got added. There likely is an issue here. @malberts can you check?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
With the additional logic in this function, it becomes appealing to extract that body of the loop into a ne function
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Do we need to have those messages in here? Can't all messages in on the top level in `buildViewModel`?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This type of test adds little value because it is not testing logic. It is testing wiring, and doing so directly, on the unit test level. If the wiring is wrong, like using the wrong key, the test ...
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Agree sharability of AND/OR selection state when nothing is selected in a list facet is unimportant. Being able to toggle to AND or OR while a list facet is empty is important. Not reloading the p...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
What are the benefits? Sounds plausible, but I don't immediately see what is gained (and idk what `AbstractQuery` is) Currently this class seems sane enough, so I expect the gain to at most be g...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Is this "just" a case of being wasteful by parsing too much? Structurally the PR seems good. Some wasteful parsing probably has little or no real-world impact
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There does not seem to be any test for the common-ish use case of open ranges (only min or only max)
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I suspect this would be clearer without the loop, but that is a minute CS difference
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Is this partial import on purpose?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Could be FacetQueryBuilder instead of DelegatingFacetQueryBuilder
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Sounds good
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Ah, you are thinking about the naming from the HTML perspective. Unfortunate that the text there is called label, overloading that one term with multiple meanings. Not immediately obvious to me ...