Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Create Elasticsearch fields
AC: * Add dedicated Elastic field per configured facet * example: `wbfs_P42` Related: * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/39JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Good candidate for own service Similar code in Semantic Wikibase: https://github.com/ProfessionalWiki/SemanticWikibase/blob/master/src/Translation/DataValueTranslator.php#L26
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I suspect something like this will be nice: ```php private function getStatements(): StatementList { return $this->getStatementsLookup()->getStatements(); } private function getStatem...
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Stating the obvious: this logic should be in instantiable class(es).
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`Facet` does not seem needed in the name
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add initial search fields 05a739a
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add initial search fields
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/49 Creates an Elasticsearch field for each configured facet. Example in Kibana: ![Screenshot_20241229_231759](https://git...JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Which makes me think we could go further than extracting a getFieldTypeForPropertyId method as suggested above, and instead make that a service.
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I did some double checking about this approach, in particular if it's better to use Wikibase's internal type, and it seems good as it is. Here is what I did in Semantic Wikibase, which has a ful...
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This line and the above try catch could also be in its own method: getFieldTypeForPropertyId
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I suspect we can do `} catch ( Exception ) {` given we use modern PHP
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`$name` can be computed closer to where it is used and the details of said computation could go into a dedicated private method.
JeroenDeDauw created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch
malberts pushed 2 commits to es-values ProfessionalWiki/WikibaseFacetedSearch
malberts pushed 1 commit to es-fields ProfessionalWiki/WikibaseFacetedSearch
- Add initial search fields c079cb4
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/51?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
WIP POC index values
Based on #50 WIP and POC. Example of an Item's statements getting indexed on the page, via sitelink: ![image](https://github.com/user-attachments/assets/9406fe52-e581-49da-b105-40ee4a5f84e7)malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
es-values - Enhanced searching interface with drilldown for Wikibase