Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

Loading...

Recent Events

jaredthomas68 created a review comment on a pull request on NREL/HOPP
I don't understand why this would decrease, but perhaps I do not understand what it is.

View on GitHub

dakrone created a review comment on a pull request on elastic/elasticsearch
This is part of why it should be `@Nullable` and optional, here we "clobber" it so that the in and out would be different: ```json "searchable_snapshot": { "total_shards_per_node": 1, "nu...

View on GitHub

dakrone created a review comment on a pull request on elastic/elasticsearch
We should treat this as optional and `@Nullable` similar to `totalShardsPerNode`

View on GitHub

jaredthomas68 created a review comment on a pull request on NREL/HOPP
I'm inclined to save this property for a separate PR.

View on GitHub

dakrone created a review comment on a pull request on elastic/elasticsearch
As I mentioned above, we should make this optional and only set if specified by the policy

View on GitHub

dakrone created a review comment on a pull request on elastic/elasticsearch
Can we make this an optional `@Nullable Integer` so that we can treat it as missing in the future? (i.e., if we wanted to change its default value somewhere in the transport action for the mounting...

View on GitHub

jaredthomas68 created a review comment on a pull request on NREL/HOPP
I think we should move the import to the top of the file

View on GitHub

Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I don't think there is any difference between the above and this shorter version. ```suggestion const makeQueryWalletCurrent = follow => (/** @type {string} */ addr) => follow('-lF', `:publish...

View on GitHub

Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion * @param {string} addr * @param {string} offerId * @param {{ follow: () => object, log: typeof console.log, setTimeout: typeof global.setTimeout}} io * @param {WaitUntilOption...

View on GitHub

jaredthomas68 created a review comment on a pull request on NREL/HOPP
Is there a reason to exclude 0 and 90?

View on GitHub