Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

alistair3149

alistair3149 pushed 1 commit to patch-hashchange-event nobbyfix/mediawiki-extensions-TabberNeue

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should we rename `$instanceTypeExtractor` to `$itemTypeExtractor`?

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should we rename `newInstanceTypeExtractor()` too?

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
That works too. On a side note, would it be more readable if the query string is broken down into an array and join together as a string?

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I thought we have to replicate the constructor like the original class for tests. Is simplification without the Config acceptable?

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 1 commit to feat-querybuilder SemanticMediaWiki/SemanticMediaWiki
  • Update docs per code review ee7fcaa

View on GitHub

alistair3149 created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Completed with #128

View on GitHub

alistair3149 closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Facet UI: Add input validation for range facet
AC: - Invalidate input when minimum is greater than maximum, or vise-versa - Disable apply button when input is invalidated - Show error state when input is invalidated - Update `min` and `max`...
alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch
  • Add missing use statement a52d9b7

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch
  • Fix incorrect const reference 2a0d716

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 2 commits to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch
  • Add try catch block for propertyId 9c861eb
  • Refactor per code review 2105908

View on GitHub

alistair3149 pushed 1 commit to feat-118 ProfessionalWiki/WikibaseFacetedSearch
  • Use boolean check directly 3160999

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
In that case, should we use `instanceOfId` or should we use `itemType`?

View on GitHub

alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Did not know that, will update it tomorrow

View on GitHub

alistair3149 created a review on a pull request on ProfessionalWiki/WikibaseFacetedSearch

View on GitHub

alistair3149 pushed 3 commits to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch
  • Follow up to #115 f443035
  • Remove PHPStan requirement to specify iterable types As per https://github.com/ProfessionalWiki/WikibaseFacetedSearc... 823e039
  • Merge branch 'master' into feat-40-1 d31f306

View on GitHub

alistair3149 pushed 1 commit to feat-40-1 ProfessionalWiki/WikibaseFacetedSearch
  • Replace itemType with instanceItemId for clarity b4eeee9

View on GitHub

alistair3149 opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add input validation for range facet
#118 Key changes: - Invalidate input when minimum is greater than maximum, or vise-versa - Disable apply button when input is invalidated - Show error state when input is invalidated - Upda...
alistair3149 created a branch on ProfessionalWiki/WikibaseFacetedSearch

feat-118 - Enhanced searching interface with drilldown for Wikibase

alistair3149 pushed 1 commit to feat-querybuilder SemanticMediaWiki/SemanticMediaWiki

View on GitHub

Load more