Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Make list facet "OR behavior" work
AC: * Can switch between AND and OR when both are enabled * Builds correct query when OR is selected * Updates query when switching from AND to OR or the other way round
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Done by https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/146
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Show item labels instead of Q-IDs
In the list facets, show item labels instead of the Q-ID values  AC: * Show Item label for the item refere...
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Sounds plausible
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
I was basing this on a pattern used on e-commerce sites. Although it does not seem to be consistent. Amazon moves the checkboxes for some facets (or maybe just the first?): 
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
I am dubious that moving the values is good UX. If as a user I select the first and the third value, I do not expect the third value to get swapped with the second one. I'd probably end up thinking...
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Move selected facet filter values to the top
Facet values are currently sorted by count (implicitly via the Elasticsearch aggregation in ElasticValueCounter, not explicitly in the query or code). The 2 selected checkboxes here should be at t...
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Hide facet filter when no values available
 The user cannot select anything, but can still collapse the facet and toggle AND/OR. This makes the facet ...
malberts closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Filter values and counts by current query
AC: * ElasticValueCounter returns ValueCounts for only results matching the current search query Follow up to * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/23 Likely has over...
malberts pushed 3 commits to feat-79 ProfessionalWiki/WikibaseFacetedSearch
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Inject current query 7e9269c
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Inject current query
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/134
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I merged master, but there seems to be an issue with other recent JS changes (likely https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/162). When clicking the "Show more" button it tri...
malberts pushed 13 commits to feat-79 ProfessionalWiki/WikibaseFacetedSearch
- Add support for OR query in the Facet UI (#162) * Add support for OR query in the Facet UI #158 * Update funct... 87d6cd3
- Handle empty OR values (#167) a41a47f
- Fix incorrect label bottom margin in Chameleon The previous selector does not cover the modal 13f783f
- Build Elasticsearch queries (#153) a699d1b
- Fix imports 0d441de
- Refactor list facet query generation logic (#169) * Refactor list facet query generation logic * Update tests 48caa0e
- Add single segment tests 9bf61cb
- Show item label instead of Q-IDs if possible (#146) * Show item label instead of Q-IDs if possible * Fix various ... 570710a
- Remove early return for empty list facet input Empty list facet input is valid and should be submitted Fixes: #172 cc6d29d
- Rename getListFacetSelectedValues to getListFacetSelectedItems 1011168
- Rename from selectedItems to selectedValues as it is more appropiate 6a15c65
- Split tabs and sidebar HTML building f18e422
- Merge remote-tracking branch 'origin/master' into feat-79 # Conflicts: # src/Presentation/ListFacetHtmlBuilder.php #... fb72d98
malberts pushed 1 commit to current-query ProfessionalWiki/WikibaseFacetedSearch
- Inject current query 531732e
malberts pushed 1 commit to current-query ProfessionalWiki/WikibaseFacetedSearch
- Inject current query 2547060
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I removed it. This was more of a theoretical fallback, although I am not sure what would cause it. At least in our case, if any tab was selected that should always casue at least some query to exist.
malberts pushed 1 commit to current-query ProfessionalWiki/WikibaseFacetedSearch
- Inject current query 9e4c7b5
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This is simpler: ```php if ( $textMatches instanceof CirrusSearchResultSet ) { self::setCurrentQuery( $textMatches->getElasticaResultSet()->getQuery()->getQuery() ); } ```
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
In which cases does the global not get set?
malberts pushed 1 commit to current-query ProfessionalWiki/WikibaseFacetedSearch
- Inject current query d53f49e
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/175?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme...
malberts opened a draft pull request on ProfessionalWiki/WikibaseFacetedSearch
Inject current query
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/134