Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
@jusdino Looks good- do we need to handle the case where a field is _added_? Naively, I wonder if it would work to just do: ```python updated_values = {key: value for key, value in new_lice...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. I leave that up to your discretion!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. That makes a lot of sense. Thanks for the thorough explanation.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I assume the explicitness was intentional, but any reason not to share fields with `LicenseGeneralResponseSchema`? Same question for the privilege schemas.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Roll back the roll back? (Just kidding.) Is this something we should have an alert on? Seems unlikely to get here, but potentially very bad?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Probably misunderstanding, but if the raw data is being served via API, what is the risk of the hash being served out via API? What additional data does that expose?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Helpful comment, thank you!
jlkravitz created a review on a pull request on csg-org/CompactConnect
good stuff! love the code reorg. few nits/comments/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
good stuff! love the code reorg. few nits/comments/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge. Sorry about that!
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it -all good. Thanks for the explanation!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If an option, why not store the version as an integer rather than as a string?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Could this ever happen? Is `attestations` not a required field?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What does this comment mean? (What is 'this'?)
jlkravitz created a comment on an issue on qdrant/qdrant
Got it. Thanks, @timvisee! Any draft documentation on the custom storage you can share? I'm particularly wondering if it'll be plug-and-play or require more extensive configuration / set-up. We're ...