Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge!
jlkravitz opened an issue on pydantic/pydantic-settings
Opaque error message when using `model_validator`
Pydantic Settings Version: 2.2.1 I get an opaque error message under certain circumstances when using the `model_validator` on a pydantic BaseSettings class. In pydantic proper, although mode...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Thank you! This reads super well and will be great to have written out in plain-speak for future devs.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
small typo: "critical ~to~ for"
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Awesome, looks great!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah ok. I had to stare at this for a while to get that, but I think I understand now. Given what I think this all does, what do you think of simplifying this logic a bit as follows? I think some ver...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah, I missed the flipped sk/pk fields. Small nit, but can we just add a brief comment saying that to facilitate the reverse lookup, we reverse the primary and sort keys?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah ok. If this understanding is correct, maybe we can update the comment to say "If We only need to suppress this if a role is being created for this lambda ```suggestion # Since this l...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. That makes sense. Could we add a little more detail to this comment, if only to clarify that "organization access logging" means "AWS account event logging" (or similar)?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Or sorry-- I meant to say, "Where, if anywhere, is the _value_ of the GSI set? i.e., where it sets which field(s) are indexed." Maybe the answer is the same, still?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it! I trust you're right, but just confirming...it looks like the docs actually _do_ use `appliesTo`? https://github.com/cdklabs/cdk-nag
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is it worth renaming one of these to make clear the distinction between them wrt caching? It seems `get_provider_user_auth_headers` only calls `get_user_tokens` if it doesn't already have a provide...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Perhaps worth adding a quick check to make sure at least (or exactly?) one provider is returned? (I realize this should never happen, but if/when a weird regression happens, a nice error message mi...
jlkravitz created a review on a pull request on csg-org/CompactConnect
Good stuff! Good documentation and testing all-around. A few comments and questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
Good stuff! Good documentation and testing all-around. A few comments and questions.
jlkravitz created a comment on a pull request on csg-org/CompactConnect
- [ ] review the pull request to get oriented - [ ] read the description of the pull request, which should summarize the changes made - [ ] read through every task on the Scrum board that's enc...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can you elaborate on this one? Not certain I understand what you mean by "future organization access logging."
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Thanks for the comments and for thinking so deeply about security on this one!