Pydantic Settings Version: 2.2.1
I get an opaque error message under certain circumstances when using the `model_validator` on a pydantic BaseSettings class.
In pydantic proper, although mode...
Ah ok. I had to stare at this for a while to get that, but I think I understand now. Given what I think this all does, what do you think of simplifying this logic a bit as follows? I think some ver...
Ah, I missed the flipped sk/pk fields. Small nit, but can we just add a brief comment saying that to facilitate the reverse lookup, we reverse the primary and sort keys?
Ah ok. If this understanding is correct, maybe we can update the comment to say "If We only need to suppress this if a role is being created for this lambda
```suggestion
# Since this l...
Got it. That makes sense. Could we add a little more detail to this comment, if only to clarify that "organization access logging" means "AWS account event logging" (or similar)?
Or sorry-- I meant to say, "Where, if anywhere, is the _value_ of the GSI set? i.e., where it sets which field(s) are indexed."
Maybe the answer is the same, still?
Is it worth renaming one of these to make clear the distinction between them wrt caching? It seems `get_provider_user_auth_headers` only calls `get_user_tokens` if it doesn't already have a provide...
Perhaps worth adding a quick check to make sure at least (or exactly?) one provider is returned? (I realize this should never happen, but if/when a weird regression happens, a nice error message mi...
- [ ] review the pull request to get oriented
- [ ] read the description of the pull request, which should summarize the changes made
- [ ] read through every task on the Scrum board that's enc...