Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is this our standard style for defining functions vs. `function singleDelimeterPhoneFormatter(...) {`? If it's the latter, could we update this file?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can we mark this as "TODO"?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can we mark this as "TODO"?
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good- few nits! Also, would it be possible to include a screenshot or two on the PR description? That'll help me visualize the code I'm reviewing, when I'm not doing manual testing. Thank you!
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good- few nits! Also, would it be possible to include a screenshot or two on the PR description? That'll help me visualize the code I'm reviewing, when I'm not doing manual testing. Thank you!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah got it. That makes a lot of sense. Is this something we can (safely) document – if not in the code itself, perhaps in a README with a reference to the README here? If you think any of these sugg...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
nit but can we add the slash here for consistency with the other URLs? I think this being the sole URL without a slash begs the question re: why it's missing, so adding it in might reduce that cogn...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Per a discussion with @landonshumway-ia last week, I believe we need to update the backend README documentation to describe how to add the frontend recaptcha token to the AWS Code Pipeline. Is that...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Why can't we style this in the Vue HTML template?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What's `grecaptcha`? Since this is from `window`, can we add a brief comment describing what this is and where it comes from?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Are these actually todo? We have test and prod codes, no?
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Few nits/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Few nits/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge!
jlkravitz created a review on a pull request on csg-org/CompactConnect
I forgot to submit the review last week...woops, sorry about that. One nit!
jlkravitz created a review on a pull request on csg-org/CompactConnect
I forgot to submit the review...woops, sorry about that. One nit!
jlkravitz created a review on a pull request on csg-org/CompactConnect
I forgot to submit the review...woops, sorry about that. One nit!
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen sorry about that!
jlkravitz created a comment on a pull request on csg-org/CompactConnect
@isabeleliassen We've added the secrets to AWS secrets manager on both test and prod, so this is now ready to merge.
jlkravitz created a review on a pull request on csg-org/CompactConnect
Got it- approving, then! @isabeleliassen Please coordinate with @jusdino re: merging this PR to minimize breakage (see above conversation for context).
jlkravitz created a review on a pull request on csg-org/CompactConnect
Approving. @isabeleliassen Please coordinate with @jusdino re: merging this PR to minimize breakage.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen update- please hold on merging, thanks!
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to merge.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. I'll go ahead and approve this PR for the sake of time, but feel free to make any edits (if needed) in a future PR.