Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a comment on a pull request on csg-org/CompactConnect
Per internal discussion with @isabeleliassen, closing this PR and combining this Sprint 16 review with next sprint's review (Sprint 17).
jlkravitz closed a pull request on csg-org/CompactConnect
Sprint 16
- [x] stand up the site locally - [ ] test all functionality in all major browsers, emphasizing the functionality that this pull request addresses - [ ] for public-facing functionality, test i...
jlkravitz created a comment on a pull request on csg-org/CompactConnect
@jusdino This is ready to merge, but before doing so, do we need to update the existing records in the test environment?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
It seems like the record still exists in the case below? @landonshumway-ia
jlkravitz opened a pull request on csg-org/CompactConnect
Sprint 16
- [ ] stand up the site locally - [ ] test all functionality in all major browsers, emphasizing the functionality that this pull request addresses - [ ] for public-facing functionality, test i...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Comment would be great, if metric name doesn't change per my other response!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah got it. I assume this is just due to AWS convention, but wouldn't you want to name the metric something like `registration-attempt` since it's being logged for each registration?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it- thanks for the background!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. Let's keep as-is, then!
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! I'd like to get last sprint's PR merged to main before merging this one, but let me know if merging this PR is more time-sensitive. If not, I will officially approve and ask Isabel to m...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Design question: Does AWS not provide its own throttling capabilities?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Could this just be a sort on (status, dateOfIssuance)?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Just wondering: why not include these fields in the GSI, rather than filter for them separately?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
not true for this test, right?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
`daily-registration-attempts`?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
```suggestion def _get_api_event(self): ```
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
should this be named `registration-attempts`?
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Few small questions/comments.
jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Few small questions/comments.
jlkravitz created a comment on a pull request on csg-org/CompactConnect
- [ ] review the pull request to get oriented - [ ] read the description of the pull request, which should summarize the changes made - [ ] read through every task on the Scrum board that's enc...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Ready to merge.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Any reason this can't be typed more narrowly?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is this called twice if the above conditional block runs? (And is that a problem?)
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
should this be... ```suggestion it('should prepare a PrivilegeAttestation for server request through serializer', () => { ```