Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

jlkravitz

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Created ticket #481

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect

View on GitHub

jlkravitz opened an issue on csg-org/CompactConnect
Military affiliation submission flow
After submitting my attestation and military affiliation documentation, the page confusingly remains on the "Update military status page" when I would otherwise expect it to redirect to the militar...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Created ticket #480

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect

View on GitHub

jlkravitz opened an issue on csg-org/CompactConnect
End military affiliation should only be possible if affiliation is Active
As a provider, I have not uploaded any military affiliation data, yet I have the option to "End military affiliation." <img width="759" alt="image" src="https://github.com/user-attachments/asse...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Added ticket #479

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect

View on GitHub

jlkravitz opened an issue on csg-org/CompactConnect
Editing your own permissions
As a Board ED, I can edit my own permissions when reviewing users. This creates the odd scenario where I can remove compact-level admin privileges on my own account, which suddenly prevents me from...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah, got it. The more you know!

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect

View on GitHub

jlkravitz created a comment on an issue on qdrant/qdrant
@timvisee FYI, if helpful, the qdrant server now seems to be looping (tries to load, crashes, restarts, etc.). It finally finished a full reboot after 5ish attempts. ``` _ ...

View on GitHub

jlkravitz created a comment on an issue on qdrant/qdrant
We're uploading 800M vectors with a payload that contains an internal ID of ~30 characters. The input is in an HDF5 format, and is 776GB. When I run the upload again on a new collection, the error...

View on GitHub

jlkravitz created a comment on an issue on qdrant/qdrant
@timvisee I upgraded and got further in the upload, but still get the error "Error: Error in the response: The operation was cancelled Timeout expired." The qdrant server logs are below. The error...

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What changed here?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
nit, but I like to prefix boolean functions with is, has, etc. I also think this is simple enough to make into a one-liner, e.g. ```suggestion isLicenseActive(license: License) { r...

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Small nit/question.

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
Looks good! Small nit/question.

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to merge.

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Should we also assert that transactions from other jurisdictions are _not_ in the report specific to this jurisdiction?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Thanks for adding these math comment/footnotes!

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Should this be prefixed with an underscore since it's a private method?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is this necessarily true for some of the errors, e.g. "Some providers were not found in the database."?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Should this be prefixed with an underscore since it's a private method?

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
Few questions!

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Does the fact that this takes the first origin matter? (vs. the 2nd, 3rd, etc.)

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Perhaps a silly question, but at this point in the code, is `allowed_origins` not static? Why can't we directly dump the list of origins into the gateway response?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Do we intentionally not check for status 200 here like we do in the other tests?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Wouldn't we not expect a 200 response for an unallowed origin?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can we use `local_ui_port` here instead of hardcoding 3018, or does that fall under the restrictions you described in the PR description?

View on GitHub

Load more