Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Isn't `ALLOWED_ORIGINS` set to `["https://example.org", "http://localhost:3018"]` in `backend/compact-connect/lambdas/python/common/tests/__init__.py`?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
#frontend #hotfix On "End Military Affiliation" modal, additional tab is required to get keyboard focus on the modal itself (rather than on elements behind the modal). To reproduce, navigate...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
#frontend #hotfix See screenshot- issue with keyboard navigation. <img width="792" alt="image" src="https://github.com/user-attachments/assets/d01fb88a-1cbc-4530-afcd-ce20100e25c2" />
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
#frontend #hotfix Logo missing label on mobile (accessibility)- needs update in `webroot/src/components/Page/PageMainNav/PageMainNav.vue` > This element has role of "button" but does not have...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@jsandoval81 @jusdino Apologies for the delay on this one. Per last sprint review discussion, I'm going to try to meet with @isabeleliassen to prioritize and demonstrate the kinds of things that co...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@jsandoval81 @jusdino Apologies for the delay on this one. Per last sprint review discussion, I'm going to try to meet with @isabeleliassen to prioritize and demonstrate the kinds of things that co...
jlkravitz opened a pull request on csg-org/CompactConnect
Sprint 15
- [ ] stand up the site locally - [ ] test all functionality in all major browsers, emphasizing the functionality that this pull request addresses - [ ] for public-facing functionality, test i...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
@jusdino Looks good- do we need to handle the case where a field is _added_? Naively, I wonder if it would work to just do: ```python updated_values = {key: value for key, value in new_lice...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. I leave that up to your discretion!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. That makes a lot of sense. Thanks for the thorough explanation.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I assume the explicitness was intentional, but any reason not to share fields with `LicenseGeneralResponseSchema`? Same question for the privilege schemas.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Roll back the roll back? (Just kidding.) Is this something we should have an alert on? Seems unlikely to get here, but potentially very bad?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Probably misunderstanding, but if the raw data is being served via API, what is the risk of the hash being served out via API? What additional data does that expose?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Helpful comment, thank you!
jlkravitz created a review on a pull request on csg-org/CompactConnect
good stuff! love the code reorg. few nits/comments/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
good stuff! love the code reorg. few nits/comments/questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge. Sorry about that!
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.