Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it -all good. Thanks for the explanation!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If an option, why not store the version as an integer rather than as a string?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Could this ever happen? Is `attestations` not a required field?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What does this comment mean? (What is 'this'?)
jlkravitz created a comment on an issue on qdrant/qdrant
Got it. Thanks, @timvisee! Any draft documentation on the custom storage you can share? I'm particularly wondering if it'll be plug-and-play or require more extensive configuration / set-up. We're ...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
@ChiefStief Flagging this before we merge. If this is something we've been doing across our codebase, we can ignore!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it - thanks for the explanation!
jlkravitz created a comment on an issue on qdrant/qdrant
@generall Ah got it. We are uploading an internal ID as part of the payload. Do you have an ETA on v1.13? In the meantime, might there be a workaround?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
OK, I think I have a better understanding from reading further down. Might it make sense to just add a brief comment on this model file explaining that this model technically models two versions of...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can we document why we have to do this? (Is this standard in our codebase? It's possible I've just missed it in the past.)
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
why is casting required here?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I'm confused by this comment - is this a comment on the function's logic, or broader conceptual documentation about the API? If the latter, can we hoist it up somewhere more appropriate - perhaps t...
jlkravitz created a review on a pull request on csg-org/CompactConnect
looks great! a few small nits.
jlkravitz created a review on a pull request on csg-org/CompactConnect
looks great! a few small nits.
jlkravitz opened an issue on qdrant/qdrant
Error when uploading large collection
Reposting a similar issue I posted on the Rust client repository, which continues to affect our team and which we suspect is an issue with QDrant and not the Rust client: https://github.com/qdrant/...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it- thank you for the context!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ahh, ok. I guess that then begs the question as to why server endpoints may not be idempotent? That seems unnecessarily brittle. I am sure there are reasons beyond my understanding, but is that rea...