Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz pushed 1 commit to main jlkravitz/dotfiles
- Separate dotfile symlinking into its own script so that it can still be used in non macOS environments (e.g., ssh'ing... 9692622
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Why are we removing these requirements, yet still testing them below? (I know we had briefly discussed updated NIST guidelines several weeks ago - related? Generally, I'm keen to remove complexi...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
These variable renames are helpful to distinguish state and compact-level permissions!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If I recall from discussions with Justin, I don't think this is really about idempotency. I believe the reason is because board ED users cannot change compact-level permissions, so any value (even ...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.
jlkravitz created a review on a pull request on csg-org/CompactConnect
This looks great! No obvious issues from initially clicking through the UI. @isabeleliassen Good to merge this one.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I think fine to leave as-is for now until we require more (or even, another) special case.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah, yes. I flipped it!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Where is this diagram located?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If you wanted it to run at noon UTC-4, wouldn't hour be set to `8`?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I'm a bit confused by this comment. What does this mean, and what are its implications for the code in this file?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What distinguishes this code from the setup code that's been abstracted away into `_when_purchase_client_returns_transactions`, etc?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What's the purpose of passing this list into this function?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
```suggestion # we'll have to allow the principal to use any SES identity configured in the account. ```
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is there a way to organize the json files a little differently so we can avoid this one-off case?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What about the case where `FROM_ADDRESS` is not defined at all?
jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!
jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!