Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aretrace created a comment on a pull request on facebook/stylex
# @nmn 🙌 🙌 🙌 plz keep us updated, and thank you 🥲
nonzzz created a comment on a pull request on facebook/stylex
Because the development was not synchronized in time, the history of this PR carries a lot of unnecessary noise. I think creating a new PR will be clearer, and as you said, we need clarify by @nmn
aminaopio created a comment on a pull request on facebook/stylex
> @aminaopio Should be closed and create a new one .I have synchronized some of the playground work to the last commit of the main branch. I believe Naman wanted us to base it off of better-play...
nonzzz created a comment on a pull request on facebook/stylex
@aminaopio Should be closed and create a new one .I have synchronized some of the playground work to the last commit of the main branch.
aminaopio created a comment on a pull request on facebook/stylex
> I do some change and pretty your commit in my local and put it at [cleaned](https://github.com/nonzzz/stylex/tree/clean-branch) you can view and check my branch and invite me as the collaborator....
nonzzz created a comment on a pull request on facebook/stylex
And i check the lint rule it not outdated.
nonzzz created a comment on a pull request on facebook/stylex
I do some change and pretty your commit in my local and put it at [cleaned](https://github.com/nonzzz/stylex/tree/clean-branch) you can view and check my branch and invite me as the collaborator.( ...
aminaopio created a comment on a pull request on facebook/stylex
Yeah I can do that, just let me know!
nonzzz created a comment on a pull request on facebook/stylex
wait. I'll check your work at my local. If everything goes as expected, will you invite me to be a collaborator?
aminaopio created a comment on a pull request on facebook/stylex
@nmn Sorry this took so long. I fixed a majority of the lint errors, but the remaining ones are caused by the pseudo elements. I think the version of the ESLint plugin that we're using is outda...
nmn created a comment on a pull request on facebook/stylex
@nonzzz is correct. All the relevant changes for this PR are for the website that doesn't use types or tests. So none of the signals should be red once your PR is clean.
nmn pushed 1 commit to main facebook/stylex
- Feat: Using `@dual-bundle/import-meta-resolve` replace `esm-resolve` (#824) * chore: using dual import-meta-resolve ... edc9b2a
nmn closed a pull request on facebook/stylex
Feat: Using `@dual-bundle/import-meta-resolve` replace `esm-resolve`
## What changed / motivation ? In the past we used `esm-resolve` to resolve es-based projects. But we need write two sets of code for `cjs` and `esm`. In `cjs` we using `require.resolve` and in ...
nonzzz created a comment on a pull request on facebook/stylex
Some ides. I think you can create a new branch based on the latest commit of the main branch. then using `cherry-pick` pick this `96ea090cc4371211c23891efc76d502fac939209` to the new branch.
nonzzz created a comment on a pull request on facebook/stylex
I think you should make this pull request commit as clean as possible. Now i note this pull request contain the main branch commit it's not need.
aminaopio created a comment on a pull request on facebook/stylex
@nmn Rebased even-better-playground onto better-playground. There shouldn't be any conflicts this time, but there are some checks failing
aminaopio created a comment on a pull request on facebook/stylex
New PR is here: https://github.com/facebook/stylex/pull/826
aminaopio closed a pull request on facebook/stylex
feat: source editor that supports multiple files
## What changed / motivation ? The StyleX website has an empty-ish page for the playground. This tackles one of the issues: A source editor pane that support tabs for multiple files. ## Linke...
aminaopio opened a draft pull request on facebook/stylex
feature: playground sidebar w/ loading indicator/dropzone
## What changed / motivation ? The StyleX website has an empty-ish page for the playground. This partially tackles one of the issues: A source editor pane that support tabs for multiple files. Inc...