Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nmn opened a pull request on facebook/stylex
feat: exported return types of 'stylex.types.*' fns
## What changed / motivation ? Fixes #857 New types are exported such as `stylex.Color` and `stylex.Length`. These are the return types of the `stylex.types.*` function. So, for example, ...
nmn created a branch on facebook/stylex
feat/export-type-types - StyleX is the styling system for ambitious user interfaces.
nmn created a comment on an issue on facebook/stylex
I see the issue. AFAIK, this is a recent change in Typescript but it's easy to fix. Putting up a PR now.
nmn created a review comment on a pull request on facebook/stylex
Don't use `fs.access`. Use `fs.exists` instead. That returns a boolean and won't throw an error.
nmn closed a pull request on facebook/stylex
fix: invalid initial-value in @property
## What changed / motivation ? When creating `@property` declarations for CSS variables created for dynamic styles, should not contain `initial-value: "*"`. This actually sets the variables t...
nmn created a comment on an issue on facebook/stylex
@yasuhiro-yamamoto Sorry, my issue had the wrong expected output. I've reviewed your PR with correct expansion.
nmn pushed 1 commit to feat-relative-cache-path facebook/stylex
- fix: add cache invalidation when on config change (#862) 411be7a
nmn closed a pull request on facebook/stylex
fix: add cache invalidation on config change
## What changed / motivation ? Let's invalidate the cache whenever StyleX config options change: - Stringify config (without input/output paths, as accounted for) into key sorted JSON, hash out...
nmn opened an issue on facebook/stylex
Define `stylex.positionTry` and `stylex.viewTransitionClass` APIs
CSS now has a `@position-try` at rule which is used as values. This is similar to `stylex.keyframes` and needs a similar API. Similarly, there is now `view-transition-class` which need global rule...
nmn created a review comment on a pull request on facebook/stylex
This is not how border-radius values are expanded. The correct expansion should be: ```suggestion test('Splits a string of values with slash notation appropriately.', () => { expect(...
nmn created a review on a pull request on facebook/stylex
Thanks for trying to fix this edge case, but the logic isn't quite right. (Note: also, this code path is only used if you use the `legacy-expand-shorthands` configuration which should not be nee...
nmn created a review on a pull request on facebook/stylex
Thanks for trying to fix this edge case, but the logic isn't quite right. (Note: also, this code path is only used if you use the `legacy-expand-shorthands` configuration which should not be nee...
nmn closed an issue on facebook/stylex
Not working @stylexjs/postcss-plugin: 0.10.0 (@property style error)
### Describe the issue Hi !) help plz) Doesn't want to pass variables var(--1u5tued) in @stylexjs/postcss-plugin: 0.10.0. ```tsx <a href={`tel:${phone}`} {...stylex.props([styles.phoneIcon(isMenu...
nmn created a comment on an issue on facebook/stylex
NOTE: This won't work because you're trying to apply styles to a descendent element. Also, you're using the wrong syntax for media queries. Use something like this instead. ```tsx const MOBILE...
nmn created a review comment on a pull request on facebook/stylex
This doesn't look right. The path should not be hardcoded. You probably need to walk up the tree to find the nearest `node_modules` or `package.json` folder.
nmn created a review on a pull request on facebook/stylex
Doesn't quite look right. We can chat further if I'm wrong.
nmn created a review on a pull request on facebook/stylex
Doesn't quite look right. We can chat further if I'm wrong.
nmn pushed 1 commit to main facebook/stylex
- fix: fix readCache to use custom cache path when set (#851) * feat: replace crypto with murmurhash for cli caching *... 24e5158
nmn closed a pull request on facebook/stylex
fix: fix readCache to use custom cache path when set
## What changed / motivation ? Oversight in https://github.com/facebook/stylex/pull/792 where `readCache` is still reading from default cache path ## Testing Added more comprehensive testi...
nmn opened a pull request on facebook/stylex
fix: invalid initial-value in @property
## What changed / motivation ? When creating `@property` declarations for CSS variables created for dynamic styles, should not contain `initial-value: "*"`. This actually sets the variables t...