Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
es-fields - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Refactor FacetConfigList 14037fe
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Refactor FacetConfigList
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/41#discussion_r1885866233 And I need to get all configured facets in #49.
malberts pushed 1 commit to refactor-list ProfessionalWiki/WikibaseFacetedSearch
- Refactor FacetConfigList 756ac05
malberts pushed 1 commit to refactor-list ProfessionalWiki/WikibaseFacetedSearch
- Refactor FacetConfigList 4baa3e5
malberts pushed 1 commit to refactor-list ProfessionalWiki/WikibaseFacetedSearch
- Refactor FacetConfigList 2a89371
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Needed for https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/49
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/48?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Refactor list
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/41#discussion_r1885866233
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
refactor-list - Enhanced searching interface with drilldown for Wikibase
malberts pushed 13 commits to facet-parser ProfessionalWiki/WikibaseFacetedSearch
- Add covers tag fa75f33
- Add TODOs dc7d795
- Move interfaces out of /Persistence/ 7593896
- Inject Config into FacetUiBuilder 4ad1757
- Improve naming of "instance of id" e452e19
- Access facets in FacetUiBuilder 778f537
- Add ConfigPageTest bb66f01
- Fix import e92e6cf
- Add new keyword placeholder f7ab999
- Adjust exmample P-IDs 346903a
- Add @covers tag d4513ed
- Give $itemType to FacetUiBuilder a9157ab
- WIP SearchTermParser 6364ad9
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> If they did not filter, we do not show any facets, beyond the item type selector. In that case it is fine. I was under the impression the type selector would be optional, in which case we'd s...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I don't see the issue. Yes, search results can contain items of multiple types, so what? This code is not about rendering search results. We need the item type info because if the user filtered ...
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Give $itemType to FacetUiBuilder a9157ab
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Give $itemType to FacetUiBuilder
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Adjust exmample P-IDs 346903a
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I think this might not be correct. A search result can contain multiple different item instance types. Unless the user filtered on a specific type - which I believe is optional. So we would likely ...