Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/43?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
fix-ci - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add ConfigPageTest bb66f01
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add TODOs in FacetUiBuilder and make facet config accessible
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Blame WikibaseExport developers!
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We might need both, or at least another version. See https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/41/files#r1885911926
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The original idea was that we'd need to access per-item/instance facet config when building the actual facets. So to build FacetConfigList I had to decide how to keep track of the configs and that ...
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
I should have been clearer. My queries here relate more specifically to range facet filtering with either "script" or "runtime_mappings", but with the point that both are likely suboptimal for invo...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This test class was leaking state despite being in `@group Database`
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/42?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
JeroenDeDauw pushed 1 commit to ConfigPageTest ProfessionalWiki/WikibaseFacetedSearch
- Add ConfigPageTest e78af84
JeroenDeDauw pushed 1 commit to ConfigPageTest ProfessionalWiki/WikibaseFacetedSearch
- Add ConfigPageTest c0ffbe0
JeroenDeDauw pushed 1 commit to ConfigPageTest ProfessionalWiki/WikibaseFacetedSearch
- Add ConfigPageTest 1ac84c7
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
It is common to split code into several classes but only have tests for the higher level one. In such cases it's good to include covers tags for the lower level ones in said test.
JeroenDeDauw created a branch on ProfessionalWiki/WikibaseFacetedSearch
ConfigPageTest - Enhanced searching interface with drilldown for Wikibase
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add covers tag fa75f33
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There is arguably some technical debt here, but it's fully contained, so it does not matter. Two guidelines violated here: * Compute things when you need them, don't put them in place just in c...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I ended up adding the below `getFacetConfigForInstanceType`, which is what made me put the TODO on this function.