Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add FacetConfig (#35) ee1bb2a
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add FacetConfig
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/13 Config page:  The documentat...
malberts pushed 1 commit to facets-config ProfessionalWiki/WikibaseFacetedSearch
- Add FacetType enum b256dda
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Agreed, we can use an Enum. No need to support adding widget types via extensions to WBFS
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/36?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Make currentMin and currentMax more explicit
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/34#discussion_r1880225138
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
current - Enhanced searching interface with drilldown for Wikibase
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/35?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I added this because the default 8 space indent looks bad on the config page.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This should be something more specific than a string. I don't think we need a full widget registry, and instead an enum will be fine.
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add FacetConfig
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/13 Config page: 
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
facets-config - Enhanced searching interface with drilldown for Wikibase
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We might be installing PHPStan in the extension itself, ignoring MW dependencies. Such an approach is often needed to avoid conflicts with those MediaWiki pins or to be able to use PHPUnit that is ...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Boundaries might be a UX requirement if we do the slider, otherwise there's no limit to where you slide. But otherwise as far as the query goes, there is no technical requirement for boundaries. If...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
MW actually pins it as "1.1.4", but we're getting composer dependencies in both MW and separately in the extension. MW's `vendor` has the right version. I think something weird was going on with PH...
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add Mustache-based FacetUiBuilder
For #9 Only minimally styled. 
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Ah, so these min and max are `currentMin` and `currentMax`. That's not obvious in the caller code, where I was thinking they represent `rangeMin` and `rangeMax`. I'm happy these are the current val...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
BEM?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
So the reason you need a new desk is that MediaWiki devs can't define their dependencies? Bit of a weird approach in MediaWiki. Either you get inappropriate pinning like `5.21.6.47.1.9.52.3`, or...