Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Sitelink refactor
* Add ItemPageLookupFactory to allow for non-sitelink page lookups. * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/24#discussion_r1864322169 * https://github.com/ProfessionalWik...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`rewriteLinkForNonEntityResult` basically reimplements this: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/3f636e441cf070234bfcd4f217603d2e2a0be28a/repo/includes/Hooks/HtmlPageLin...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I figured it would be slightly more testable than being directly in the extension factory (where we don't typically expect, and test, logic). But then again it's also slightly YAGNI since there are...
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
`ruflin/elastica` supports running raw queries: https://elastica.io/example/raw-json-query.html
malberts closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Rewrite search result link to page in sitelinks
Partial follow-up to #3 Wikibase items in the search results need to link to a wiki page based on a specific sitelink.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I wonder if the call to `rewriteLinkForNonEntityResult` in the hooks file is being skipped over in cases it should not when we always return null.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
What motivated you to put this factory logic into a dedicated class? (I'm not objecting)
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Someone wants their 100% code coverage :D
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Sitelink refactor
* Add ItemPageLookupFactory to allow for non-sitelink page lookups. * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/24#discussion_r1864322169 * https://github.com/ProfessionalWik...
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
sitelink-refactor - Enhanced searching interface with drilldown for Wikibase
malberts closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Create config page
`MediaWiki:WikibaseFacetedSearch` Similar to https://professional.wiki/en/extension/wikibase-export#Configuration (can get code from https://github.com/ProfessionalWiki/WikibaseExport) AC: *...
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add config page
For #12 Based on https://github.com/ProfessionalWiki/WikibaseExport config. Supports JSON config in LocalSettings and on `MediaWiki:WikibaseFacetedSearch`. Adds config for sitelink: https://g...
malberts pushed 1 commit to config ProfessionalWiki/WikibaseFacetedSearch
- Use config for sitelink site ID 34d362f
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Yes. I'll update this now that https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/24 is merged.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
configuration. Not appropriate to abbreviate here