Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
It seems that this config is still unused. Is that correct?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
NumericPropertyId unused, PropertyIdList undefined
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink (#24) 574e5a1
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There is a lot of static code here. Likely we can move much to one or more classes that do not bind to globals and can be tested easier
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The `array_filter()[0] ?? null` could go into its own function
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/25?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen...
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add config
For #12 On `Special:SpecialPages`:  Empty `MediaWiki:WikibaseFacetedSearch`: 
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
config - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink 40b092b
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink 43d72f7
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink 633f757
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
For EntityResult results we just need to point to the new page, since the correct $titleSnippet gets set in `CirrusShowSearchHitHandler::onShowSearchHitTitle()`.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
For non-EntityResult there is no $titleSnippet by default, which means the link is going to use the text of the target page title, not the item title. To get the item title again, this calls a m...
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
All 4 scenarios work after rewriting this. 1. When searching with a mix of namespaces (Item and Main):  ...
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink a1e51cf
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
When replacing $title, the link gets the text from the new Title object. We want to keep the original Item title, so we have to let the original link text builders run.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This is for PHPStan to understand `class_alias()`.
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink 04cb34d
malberts pushed 1 commit to sitelink ProfessionalWiki/WikibaseFacetedSearch
- Rewrite item link with page sitelink 5780501