Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
You're right. I can't see any way a `Poco::MD5Engine` takes a `Poco::FIleInputStream`. I don't know if I misread when I wrote the comment or I assumed it would exist :roll_eyes:
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
You don't use `getTypeClass` because you really need to point to a valid object of the type, right?
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
This should probably be a `LOGICAL_ERROR`, but if you really want to use `assert` here and in other places, you'd rather use `chassert` which reports much nicer
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Not a big issue, but I've seen `std::vector<String>` quite a few times already. There's a `Strings` defined in `src/Core/Types.h`
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
This code is exactly the same as in L367-369. Not a big issue, but maybe could be refactored so the same code returns these three things?
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Comments use 3 slashes and need a whitespace afterwards: ``` /// Like this ```
pamarcos closed a pull request on ClickHouse/ClickHouse
Run StyleCheck and FastTest in parallel
Run StyleCheck and FastTest in parallel to speed up the CI ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readable ...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Running them in parallel https://github.com/ClickHouse/ClickHouse/actions/runs/12907896881?pr=74916 
pamarcos opened a pull request on ClickHouse/ClickHouse
Run StyleCheck and FastTest in parallel
WIP ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes that goes to CHANGELOG...
pamarcos created a branch on ClickHouse/ClickHouse
parallelize-stylecheck-and-fasttest - ClickHouse® is a real-time analytics database management system
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I still find these kind of String concatenation using `+=` incredibly ugly because it makes harder to understand the final String generated. I still recommend using `fmt::format` or `std::format` i...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
@maxknv what's blocking us from merging this?
pamarcos closed a pull request on ClickHouse/ClickHouse
Add needed includes and files to use Azure's key vault
Add includes and missing files in order to use Azure's key vault. I've checked it works using their own encryption/decryption example in this commit: [`39875ee` (#74812)](https://github.com/ClickHo...
pamarcos pushed 4 commits to 24.3 ClickHouse/ClickHouse
- Backport #74144 to 24.3: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 3ad9c2b
- Add semicolon at the end of the statement f769e95
- Fix test for old client version 6123394
- Merge pull request #74802 from ClickHouse/backport/24.3/74144 Backport #74144 to 24.3: Fix security issue to prevent... 2e6f08e
pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.3: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74801 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos pushed 3 commits to add-azure-key-vault ClickHouse/ClickHouse