Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
You're not using this static method here, but I'm assuming this is the one that you'd like to use to extract from a filename the hash and the suffix, right? In any case, it doesn't work. ```c...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
I'd move the implementation into its own `TemporaryReplaceTableName.cpp`. The header files are already cluttered as they are, increasing compilation time. Let's not increase it even further if we c...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
I'd move the implementation into its own `TemporaryReplaceTableName.cpp`. The header files are already cluttered as they are, increasing compilation time. Let's not increase it even further if we c...
pamarcos closed a pull request on ClickHouse/ClickHouse
Make BloomFilterIndex support datatype DateTime64
<!--- A technical comment, you are free to remove or leave it as it is when PR is created The following categories are used in the next scripts, update them accordingly utils/changelog/changelog...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
Code LGTM, after merging with master all tests are passing except for a flaky test. Sorry for the very late review, @YutSean. Thanks a lot for your contribution :)
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I didn't know that. If we're already using it across our documentation, I'm perfectly fine with it :+1:
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
The mention to `UInt*` is confusing/misleading to me. Is it a pointer to an UInt? I don't think so... it rather looks like a typo. I see it comes from https://clickhouse.com/docs/en/engines/table-e...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
I've merged master because the PR branch was very outdated. Hopefully the CI will run ok this time :crossed_fingers:
pamarcos created a review on a pull request on ClickHouse/ClickHouse
I modified the description to leave only one entry in the `Changelog category` and re-triggered the RunConfig to pick it up so that the rest of the CI runs
pamarcos pushed 1 commit to dt64 YutSean/ClickHouse
- Fix submodules after wrong automatic merge from git :( 24f32a6
pamarcos pushed 10000 commits to dt64 YutSean/ClickHouse
- Fix FreeBSD build 3f33597
- Fix ASAN failure 95cb582
- Misc fixes c0ff129
- Change hardening more to extensive 222c751
- Fix more container overflows 3ba63fa
- Corrections 14ebc48
- Style 4911d67
- Style [2] 8e47e1a
- Bump 92656aa
- Merge pull request #73479 from yariks5s/hive_partitioning_fixes Fixes regarding hive partitioning 7ce63aa
- Cleanup code and cmake 5363ee9
- Merge branch 'master' into issues/69286/enable 682e2c2
- Fix for many nested cases 57a4506
- Forgot to update 5e8cf07
- Merge pull request #73699 from ClickHouse/fix_repeated_wait_and_throw Fix for repeated call of ThreadPoolCallbackRun... 985b82e
- Check if tables are available b94fe77
- Fix default hostname 50a9854
- Use a less confusing method name 8b5bfaa
- Clean up 42716b1
- Merge remote-tracking branch 'origin/master' into pr-subquery-with-non-replicated ea5f1f8
- and 9980 more ...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Also just realized you missed to skip it for fast tests: ``` -- Tags: no-fasttest ```
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Got it, merge it freely whenever you deem so
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I know you mentioned in the description changes in [`fba1fc4` (#74114)](https://github.com/ClickHouse/ClickHouse/pull/74114/commits/fba1fc406257b9ffe21d088f393f45599c934e94) are unrelated, but sin...
pamarcos created a comment on an issue on ClickHouse/ClickHouse
https://github.com/htuall is the student that is going to convey this task :muscle: I assigned the issue to myself for now because GitHub doesn't allow me to assign it to any people. I hope once ...
pamarcos opened an issue on ClickHouse/ClickHouse
Instrumentation with LLVM XRay
## Goal from https://github.com/ClickHouse/ClickHouse/issues/71175 When the code is compiled with LLVM XRay, it adds a space in entry and exit of each large function (filled with nop instruction...
pamarcos pushed 1 commit to sanitize-postgresql-table-function-params ClickHouse/ClickHouse
- Skip new test for fast test 320d7e1