Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

pamarcos

pamarcos created a review on a pull request on ClickHouse/ClickHouse

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

parallelize-stylecheck-and-fasttest

pamarcos closed a pull request on ClickHouse/ClickHouse
Run StyleCheck and FastTest in parallel
Run StyleCheck and FastTest in parallel to speed up the CI ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readable ...
pamarcos pushed 0 commits to parallelize-stylecheck-and-fasttest ClickHouse/ClickHouse

View on GitHub

pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Running them in parallel https://github.com/ClickHouse/ClickHouse/actions/runs/12907896881?pr=74916 ![image](https://github.com/user-attachments/assets/ed042b9b-7de3-4c34-b0c7-74ff4a933c2a)

View on GitHub

pamarcos opened a pull request on ClickHouse/ClickHouse
Run StyleCheck and FastTest in parallel
WIP ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes that goes to CHANGELOG...
pamarcos created a branch on ClickHouse/ClickHouse

parallelize-stylecheck-and-fasttest - ClickHouse® is a real-time analytics database management system

pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I still find these kind of String concatenation using `+=` incredibly ugly because it makes harder to understand the final String generated. I still recommend using `fmt::format` or `std::format` i...

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse

View on GitHub

pamarcos created a comment on a pull request on ClickHouse/ClickHouse
@maxknv what's blocking us from merging this?

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

add-azure-key-vault

pamarcos closed a pull request on ClickHouse/ClickHouse
Add needed includes and files to use Azure's key vault
Add includes and missing files in order to use Azure's key vault. I've checked it works using their own encryption/decryption example in this commit: [`39875ee` (#74812)](https://github.com/ClickHo...
pamarcos pushed 4 commits to 24.3 ClickHouse/ClickHouse
  • Backport #74144 to 24.3: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 3ad9c2b
  • Add semicolon at the end of the statement f769e95
  • Fix test for old client version 6123394
  • Merge pull request #74802 from ClickHouse/backport/24.3/74144 Backport #74144 to 24.3: Fix security issue to prevent... 2e6f08e

View on GitHub

pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.3: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74801 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos pushed 3 commits to add-azure-key-vault ClickHouse/ClickHouse
  • Revert "Force building the azure_key_vault example" This reverts commit d25870c9e428bea37cf1ec58d2bba734e2202e07. 7ccc95e
  • Revert "Ignore style check for the Azure key vault example" This reverts commit d54eb04d2a185d8f8c663d71fc173f5720d7... 2b5081c
  • Clean PR after testing the CI 8dab586

View on GitHub

pamarcos pushed 1 commit to backport/24.3/74144 ClickHouse/ClickHouse
  • Fix test for old client version 6123394

View on GitHub

pamarcos pushed 1 commit to backport/24.3/74144 ClickHouse/ClickHouse
  • Add semicolon at the end of the statement f769e95

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.8/74144

pamarcos pushed 2 commits to 24.8 ClickHouse/ClickHouse
  • Backport #74144 to 24.8: Fix security issue to prevent SQL injection in postgresql and sqlite table functions de43930
  • Merge pull request #74804 from ClickHouse/backport/24.8/74144 Backport #74144 to 24.8: Fix security issue to prevent... 4136b3a

View on GitHub

pamarcos pushed 1 commit to add-azure-key-vault ClickHouse/ClickHouse
  • Force building the azure_key_vault example d25870c

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse
I think we need to rework the `SQLType * TypeDeepCopy(SQLType * tp)` function. Using `dynamic_cast` in a if-else cascade to know how to clone something is a well-known pattern to avoid. Especially...

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse
I think we need to rework `SQLType * TypeDeepCopy(SQLType * tp)` function. Using `dynamic_cast` in a if-else cascade to know how to clone something is a well-known pattern to avoid. Especially whe...

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.10/74144

pamarcos pushed 2 commits to 24.10 ClickHouse/ClickHouse
  • Backport #74144 to 24.10: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 322149a
  • Merge pull request #74806 from ClickHouse/backport/24.10/74144 Backport #74144 to 24.10: Fix security issue to preve... 60df3fb

View on GitHub

pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.10: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74805 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.11/74144

pamarcos pushed 2 commits to 24.11 ClickHouse/ClickHouse
  • Backport #74144 to 24.11: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 4d450e4
  • Merge pull request #74808 from ClickHouse/backport/24.11/74144 Backport #74144 to 24.11: Fix security issue to preve... 0da59f2

View on GitHub

pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.11: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74807 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos pushed 1 commit to add-azure-key-vault ClickHouse/ClickHouse

View on GitHub

Load more