Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

pamarcos

pamarcos pushed 1 commit to backport/24.3/74144 ClickHouse/ClickHouse
  • Fix test for old client version 6123394

View on GitHub

pamarcos pushed 1 commit to backport/24.3/74144 ClickHouse/ClickHouse
  • Add semicolon at the end of the statement f769e95

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.8/74144

pamarcos pushed 2 commits to 24.8 ClickHouse/ClickHouse
  • Backport #74144 to 24.8: Fix security issue to prevent SQL injection in postgresql and sqlite table functions de43930
  • Merge pull request #74804 from ClickHouse/backport/24.8/74144 Backport #74144 to 24.8: Fix security issue to prevent... 4136b3a

View on GitHub

pamarcos pushed 1 commit to add-azure-key-vault ClickHouse/ClickHouse
  • Force building the azure_key_vault example d25870c

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse
I think we need to rework the `SQLType * TypeDeepCopy(SQLType * tp)` function. Using `dynamic_cast` in a if-else cascade to know how to clone something is a well-known pattern to avoid. Especially...

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse
I think we need to rework `SQLType * TypeDeepCopy(SQLType * tp)` function. Using `dynamic_cast` in a if-else cascade to know how to clone something is a well-known pattern to avoid. Especially whe...

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.10/74144

pamarcos pushed 2 commits to 24.10 ClickHouse/ClickHouse
  • Backport #74144 to 24.10: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 322149a
  • Merge pull request #74806 from ClickHouse/backport/24.10/74144 Backport #74144 to 24.10: Fix security issue to preve... 60df3fb

View on GitHub

pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.10: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74805 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos deleted a branch ClickHouse/ClickHouse

backport/24.11/74144

pamarcos pushed 2 commits to 24.11 ClickHouse/ClickHouse
  • Backport #74144 to 24.11: Fix security issue to prevent SQL injection in postgresql and sqlite table functions 4d450e4
  • Merge pull request #74808 from ClickHouse/backport/24.11/74144 Backport #74144 to 24.11: Fix security issue to preve... 0da59f2

View on GitHub

pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #74144 to 24.11: Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/74144 Cherry-pick pull-request #74807 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos pushed 1 commit to add-azure-key-vault ClickHouse/ClickHouse

View on GitHub

pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I meant the destructor itself. The dummy implementation of the virtual methods are ok there since they're 1-liners

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse

View on GitHub

pamarcos pushed 2 commits to add-azure-key-vault ClickHouse/ClickHouse
  • Only build Azure key vault for private fork 0a1300e
  • Ignore style check for the Azure key vault example d54eb04

View on GitHub

pamarcos opened a pull request on ClickHouse/ClickHouse
Add needed includes and files to use Azure's key vault
WIP ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.m...
pamarcos created a branch on ClickHouse/ClickHouse

add-azure-key-vault - ClickHouse® is a real-time analytics database management system

pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Answering myself at https://github.com/ClickHouse/ClickHouse/pull/74727#issuecomment-2601867906, @Algunenano came up with a proper SQL to see the difference. Leaving it here just for the record: ...

View on GitHub

pamarcos closed an issue on ClickHouse/ClickHouse
SQLite table function crash
### Steps to reproduce By simply running the query ` select * from sqlite('r','\'); select 1 --');` the CH service crashes. [Fiddle example with version 24.12.3.47](https://fiddle.clickhouse.com/...
pamarcos closed a pull request on ClickHouse/ClickHouse
Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Fix security issue to prevent SQL injection in postgresql and sqlite table functions At first I thought we should sanitize and validate the parameters to check whether the database and table nam...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
It's much better than it was before :muscle: My complain is not only about your changes, but also about the code as it is now: 1. Too many new/delete. Why can't we use `std::unique_ptr` and `s...

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse
It's much better than it was before :muscle: My complain is not only about your changes, but also about the code as it is now: 1. Too many new/delete. Why can't we use `std::unique_ptr` and `s...

View on GitHub

pamarcos pushed 239 commits to sanitize-postgresql-table-function-params ClickHouse/ClickHouse
  • compression level for parquet output format 6c8f74b
  • parallel encoding does not affect 0e8ccfb
  • add compression level for custom encoder 7fe95dc
  • Merge branch 'master' into parquet_compression_level 2846418
  • add to settings change history 02bb10d
  • no fast-test 5b12809
  • truncate file on insert for tests b892ef0
  • re-use existing setting 99c8787
  • Update build-osx.md (ru) update brew install list (like in en version) delete double command 97b4c17
  • Improve ClickHouse Client docs. 3e72c5d
  • Fix typos. e48ebf3
  • Merge branch 'master' into parquet_compression_level 6468c96
  • Fix detection of "use the Rewrite method in the JSON API" for native copy on GCS The problem was that the default S3... 063a654
  • Fix native copy settings for RESTORE from base backup Before this patch the following settings has not been copied f... 37a9e81
  • tests: cover native copy during RESTORE from base backup Signed-off-by: Azat Khuzhin <[email protected]> e913bc2
  • Allow to skip skip index build in merges fa69fa8
  • Add install step. f917a2d
  • Added more friendly iceberg table explanation * Now you can't see table name when you do EXPLAIN, so it is hard to u... 7ffe05d
  • test test 7bfb404
  • fixed style 0305562
  • and 219 more ...

View on GitHub

pamarcos created a review on a pull request on ClickHouse/ClickHouse

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

move-integration-test-flaky-to-tests_1

pamarcos closed a pull request on ClickHouse/ClickHouse
Set Integration test flaky as required to move it to Tests_1
Set Integration test flaky as required to move it to Tests_1 ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readabl...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
> Oh, the idea is because clang-tidy is now so cheap we can afford to run it earlier and also find problems earlier. @rschu1ze Exactly! I think here you pinged the wrong Pablo/Pedro :stuck_out_t...

View on GitHub

pamarcos deleted a branch ClickHouse/ClickHouse

test-ci-changing-only-an-integration-test

Load more