Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I meant the destructor itself. The dummy implementation of the virtual methods are ok there since they're 1-liners
pamarcos pushed 2 commits to add-azure-key-vault ClickHouse/ClickHouse
pamarcos opened a pull request on ClickHouse/ClickHouse
Add needed includes and files to use Azure's key vault
WIP ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.m...
pamarcos created a branch on ClickHouse/ClickHouse
add-azure-key-vault - ClickHouse® is a real-time analytics database management system
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Answering myself at https://github.com/ClickHouse/ClickHouse/pull/74727#issuecomment-2601867906, @Algunenano came up with a proper SQL to see the difference. Leaving it here just for the record: ...
pamarcos closed an issue on ClickHouse/ClickHouse
SQLite table function crash
### Steps to reproduce By simply running the query ` select * from sqlite('r','\'); select 1 --');` the CH service crashes. [Fiddle example with version 24.12.3.47](https://fiddle.clickhouse.com/...
pamarcos closed a pull request on ClickHouse/ClickHouse
Fix security issue to prevent SQL injection in postgresql and sqlite table functions
Fix security issue to prevent SQL injection in postgresql and sqlite table functions At first I thought we should sanitize and validate the parameters to check whether the database and table nam...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
It's much better than it was before :muscle: My complain is not only about your changes, but also about the code as it is now: 1. Too many new/delete. Why can't we use `std::unique_ptr` and `s...
pamarcos created a review on a pull request on ClickHouse/ClickHouse
It's much better than it was before :muscle: My complain is not only about your changes, but also about the code as it is now: 1. Too many new/delete. Why can't we use `std::unique_ptr` and `s...
pamarcos pushed 239 commits to sanitize-postgresql-table-function-params ClickHouse/ClickHouse
- compression level for parquet output format 6c8f74b
- parallel encoding does not affect 0e8ccfb
- add compression level for custom encoder 7fe95dc
- Merge branch 'master' into parquet_compression_level 2846418
- add to settings change history 02bb10d
- no fast-test 5b12809
- truncate file on insert for tests b892ef0
- re-use existing setting 99c8787
- Update build-osx.md (ru) update brew install list (like in en version) delete double command 97b4c17
- Improve ClickHouse Client docs. 3e72c5d
- Fix typos. e48ebf3
- Merge branch 'master' into parquet_compression_level 6468c96
- Fix detection of "use the Rewrite method in the JSON API" for native copy on GCS The problem was that the default S3... 063a654
- Fix native copy settings for RESTORE from base backup Before this patch the following settings has not been copied f... 37a9e81
- tests: cover native copy during RESTORE from base backup Signed-off-by: Azat Khuzhin <[email protected]> e913bc2
- Allow to skip skip index build in merges fa69fa8
- Add install step. f917a2d
- Added more friendly iceberg table explanation * Now you can't see table name when you do EXPLAIN, so it is hard to u... 7ffe05d
- test test 7bfb404
- fixed style 0305562
- and 219 more ...
pamarcos closed a pull request on ClickHouse/ClickHouse
Set Integration test flaky as required to move it to Tests_1
Set Integration test flaky as required to move it to Tests_1 ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readabl...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
> Oh, the idea is because clang-tidy is now so cheap we can afford to run it earlier and also find problems earlier. @rschu1ze Exactly! I think here you pinged the wrong Pablo/Pedro :stuck_out_t...
pamarcos closed a draft pull request on ClickHouse/ClickHouse
Test the CI after changing only an integration test
Test the CI after changing only an integration test ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short des...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
From https://github.com/ClickHouse/ClickHouse/actions/runs/12828587564/job/35772946165. It's alive! 
pamarcos created a comment on an issue on ClickHouse/ClickHouse
Tip from @qoega to visualize in a flamegraph the CI: ```sql SELECT if(instance_id == '', (rand()::UInt8)::String, instance_id) AS group, commit_sha, check_name AS operation_name, ...
pamarcos opened a pull request on ClickHouse/ClickHouse
Set Integration test flaky as required to move it to Tests_1
Set Integration test flaky as required to move it to Tests_1 ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not required) ### Changelog entry (a user-readabl...
pamarcos created a branch on ClickHouse/ClickHouse
move-integration-test-flaky-to-tests_1 - ClickHouse® is a real-time analytics database management system
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Done in [`c31de2d` (#74144)](https://github.com/ClickHouse/ClickHouse/pull/74144/commits/c31de2dd7fe555c6e074e4828ca83d142e802c2b)
pamarcos pushed 1 commit to sanitize-postgresql-table-function-params ClickHouse/ClickHouse
- Check the exception error is as expected c31de2d
pamarcos created a comment on an issue on ClickHouse/ClickHouse
> 1. How does the CI determine that a modified test should only be run in the "Stateless tests flaky check (asan)" job variant? While the test modification might pass in this variant, it could ...
pamarcos closed an issue on ClickHouse/ClickHouse
[RFC] Disable merge-commit in PR template
Using a merge commit does not guarantee that the PR is synced with master, it only guarantees the a commit was tested against master at **the time it was pushed**. In other words, the merge-commit ...
pamarcos pushed 1 commit to sanitize-postgresql-table-function-params ClickHouse/ClickHouse
- Fix quoting single quotes in sqlite function 7617d1b
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
I think the tests that failed have nothing to do with your changes. You should override the `Mergeable Check` to be able to merge. Let me know if you need help or something. I didn't do it myself b...
pamarcos opened a draft pull request on ClickHouse/ClickHouse
Test the CI after changing only an integration test
Test the CI after changing only an integration test ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short des...
pamarcos created a branch on ClickHouse/ClickHouse
test-ci-changing-only-an-integration-test - ClickHouse® is a real-time analytics database management system