Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
>Sometimes, they may be defined as 0, so double-checking is good. Of course you need to check whether they're 0 or not, but you don't need to check if they're defined. They're always defined, an...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I'd expect from any `get` method to return something. Seems you're returning the result in the 3rd parameter? I've seen that throughout the code, but I don't understand why having an out parameter ...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Check these includes and the rest. We use `<>` instead of double quotes `"`
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
We should be using an `enum class` instead. Among others, that'd allow us to remove the `Int` prefix of all names, since they won't clash. ```suggestion using IntegrationCall = enum class Integ...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I think there's no need to check whether things are defined or not, because they should always be defined in the config.h ```suggestion #if USE_MYSQL # if __has_include(<mysql.h>) # ...
pamarcos pushed 1 commit to speed-up-build-tidy ClickHouse/ClickHouse
- Revert "Add linting error on purpose to test the CI" This reverts commit 4b90e75b4d5c20a7bc58bee0fc84a32900b58a73. bbe0c9c
pamarcos pushed 1 commit to speed-up-build-tidy ClickHouse/ClickHouse
- Add linting error on purpose to test the CI 4b90e75
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
> @pamarcos Yes, linking clang-tidy builds doesn't make sense. We can try to disable it in a next step. But it will be tricky ... e.g. we can try to set a custom linker in `cmake/tools.cmake` (whic...
pamarcos pushed 1 commit to speed-up-build-tidy ClickHouse/ClickHouse
- Use dummy launchers for compiler and linker when using clang-tidy fbfcfc8
pamarcos opened a draft pull request on ClickHouse/ClickHouse
Speed up build_tidy
WIP ### Changelog category (leave one): - New Feature - Experimental Feature - Improvement - Performance Improvement - Backward Incompatible Change - Build/Testing/Packaging Improvement -...
pamarcos created a branch on ClickHouse/ClickHouse
speed-up-build-tidy - ClickHouse® is a real-time analytics DBMS
pamarcos pushed 139 commits to cherrypick/24.11/73545 ClickHouse/ClickHouse
- Update autogenerated version to 24.12.1.1 and contributors 04d99cc
- Backport #72231 to 24.11: Revert "CI: Stress test with praktika" dfe4bf6
- Merge pull request #72236 from ClickHouse/backport/24.11/72231 Backport #72231 to 24.11: Revert "CI: Stress test wit... a46f203
- Backport #72209 to 24.11: Fix min_age_to_force_merge_on_partition_only 2ec0fdc
- Backport #71923 to 24.11: Fix Dynamic serialization in Pretty JSON formats 6c31d23
- Backport #71816 to 24.11: Fix JSON/Dynamic Native serialization with old server and new client and add a setting to f... 99512f9
- Merge pull request #72275 from ClickHouse/backport/24.11/71923 Backport #71923 to 24.11: Fix Dynamic serialization i... ea05e95
- Backport #72258 to 24.11: Revert "Short circuit optimization for functions executed over Nullable arguments" 48b7d5f
- Backport #72179 to 24.11: Fix bugs when using UDF in join on expression with the old analyzer db46ebe
- Merge pull request #72289 from ClickHouse/backport/24.11/72258 Backport #72258 to 24.11: Revert "Short circuit optim... 476592b
- Backport #72278 to 24.11: Fix race in `ColumnDynamic::dumpStructure()` f7b0cfb
- Backport #72233 to 24.11: Fix race in `GraceHashJoin` 59af754
- Merge pull request #72329 from ClickHouse/backport/24.11/72233 Backport #72233 to 24.11: Fix race in `GraceHashJoin` dca9e38
- Backport #71439 to 24.11: Fix transaction rollback if `WriteBuffer::finalize` fails in plain_rewritable disk during d... cf2caef
- Merge pull request #72336 from ClickHouse/backport/24.11/71439 Backport #71439 to 24.11: Fix transaction rollback if... 88504c7
- Backport #72319 to 24.11: Revert "Set enable_http_compression default value to 1" 508cd2b
- Backport #72283 to 24.11: Apply colors correctly to terminal output 87e32a9
- Merge pull request #72343 from ClickHouse/backport/24.11/72319 Backport #72319 to 24.11: Revert "Set enable_http_com... 0ea90d1
- Merge pull request #72345 from ClickHouse/backport/24.11/72283 Backport #72283 to 24.11: Apply colors correctly to t... 655a6ed
- Backport #72292 to 24.11: disable a cloud setting 34f8725
- and 119 more ...
pamarcos pushed 258 commits to cherrypick/24.10/73545 ClickHouse/ClickHouse
- Update autogenerated version to 24.11.1.1 and contributors 2e054d5
- Backport #70820 to 24.10: Fix a crash and a leak in AggregateFunctionGroupArraySorted 27a5af0
- Merge pull request #71122 from ClickHouse/backport/24.10/70820 Backport #70820 to 24.10: Fix a crash and a leak in A... ae719a0
- Backport #71129 to 24.10: Followup #70520 70bd6c2
- Merge pull request #71142 from ClickHouse/backport/24.10/71129 Backport #71129 to 24.10: Followup #70520 3c59401
- Backport #71089 to 24.10: Proj LWD Rebuild Respects Deleted Rows 1c37e50
- Merge pull request #71157 from ClickHouse/backport/24.10/71089 Backport #71089 to 24.10: Proj LWD Rebuild Respects D... df19fc9
- Backport #71133 to 24.10: Update compatibility setting for `hnsw_candidate_list_size_for_search` 4638976
- Merge pull request #71189 from ClickHouse/backport/24.10/71133 Backport #71133 to 24.10: Update compatibility settin... 604e45d
- Backport #70749 to 24.10: Check number of arguments for function with Dynamic argument 32cabf8
- Backport #71174 to 24.10: Maybe not GWPAsan by default 972c09d
- Backport #70984 to 24.10: Fix logical error in storage s3queue 3b1a0cd
- Merge pull request #71198 from ClickHouse/backport/24.10/70749 Backport #70749 to 24.10: Check number of arguments f... 34f4f17
- Merge pull request #71214 from ClickHouse/backport/24.10/70984 Backport #70984 to 24.10: Fix logical error in storag... ab6c816
- Merge pull request #71205 from ClickHouse/backport/24.10/71174 Backport #71174 to 24.10: Maybe not GWPAsan by default ce34c90
- Backport #71173 to 24.10: Fixes for interactive metrics 3ac27ac
- Merge pull request #71222 from ClickHouse/backport/24.10/71173 Backport #71173 to 24.10: Fixes for interactive metrics b788d4d
- Backport #70823 to 24.10: Fix excessive LIST API calls to the object storage in the plain_rewritable disk 5ec22a3
- Backport #70998 to 24.10: Fix named session leak. Simplify scheduling mechanism cc963d3
- Merge pull request #71234 from ClickHouse/backport/24.10/70823 Backport #70823 to 24.10: Fix excessive LIST API call... fac815c
- and 238 more ...
pamarcos pushed 2 commits to 24.12 ClickHouse/ClickHouse
pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #73545 to 24.12: Sync Google Cloud config
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/73545 Cherry-pick pull-request #73576 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos closed a pull request on ClickHouse/ClickHouse
Sync Google Cloud config
Sync Google Cloud config ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes tha...
pamarcos opened a pull request on ClickHouse/ClickHouse
Sync Google Cloud config
Sync Google Cloud config ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes tha...
pamarcos created a branch on ClickHouse/ClickHouse
sync-with-private - ClickHouse® is a real-time analytics DBMS
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Thanks for doing this. I agree using ThinLTO doesn't make any sense with clang-tidy. However, I don't think ThinLTO was the main bottleneck of the linking time. Why are we even linking, in the firs...
pamarcos pushed 1 commit to nolog Algunenano/ClickHouse
- Dummy change to trigger another build on the CI f4d62a9