Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
That'd be cool if it can be enabled/disabled on demand, but at least it's always helpful to know what needs to be configured in CMake to make something work. Searching for internal dependencies whe...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
@PedroTadim it's a huge change in terms of LOC, so please help me to review it easier. What I'd like to know: - Can we stick to the coding style of the rest of ClickHouse for our own code? Filen...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
I guess you're using some plugin to sort includes, change format the code and all that after saving, but it's making the review much more difficult, apart of not being consistent with the rest of t...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Why did you have to disable all these warnings for buzz-house? If it's for our own buzz-house code, I think we should stick to the same standards as the rest of the code. If it's third-party co...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Got it, I had to reconfigure with `ENABLE_PROTOBUF=1`. If we're going to always require protobuf for the client, I suggest we drop a nice message to help us figure out what to enable and how. W...
pamarcos pushed 3 commits to 24.3 ClickHouse/ClickHouse
- Revert "Merge pull request #71861 from pamarcos/fix-bitshift-test" This reverts commit 3b65e148f5f7548a06a6150da5414... 758486e
- Revert "Merge pull request #71731 from ClickHouse/backport/24.3/71580" This reverts commit a5b0c17a75faee84c86116526... ad7a44b
- Merge pull request #71871 from ClickHouse/revert-bitshift-backport-for-24.3 Revert "Merge pull request #71861 from p... 9c47782
pamarcos opened a pull request on ClickHouse/ClickHouse
Revert "Merge pull request #71861 from pamarcos/fix-bitshift-test"
Revert bitShift changes --> ### Changelog category (leave one): - New Feature - Experimental Feature - Improvement - Performance Improvement - Backward Incompatible Change - Build/Testing...
pamarcos closed a pull request on ClickHouse/clickhouse-docs
Fix typo
## Summary Fix typo ## Checklist - [ ] Delete items not relevant to your PR - [ ] URL changes should add a redirect to the old URL via https://github.com/ClickHouse/clickhouse-docs/blob/main/...
pamarcos opened a pull request on ClickHouse/clickhouse-docs
Fix typo
## Summary Fix typo ## Checklist - [ ] Delete items not relevant to your PR - [ ] URL changes should add a redirect to the old URL via https://github.com/ClickHouse/clickhouse-docs/blob/main/...
pamarcos created a branch on ClickHouse/clickhouse-docs
fix-typo - Official documentation for ClickHouse
pamarcos closed a pull request on ClickHouse/clickhouse-docs
Minor improvement for Profiling with XRay
## Summary Minor improvement for Profiling with XRay ## Checklist - [ ] Delete items not relevant to your PR - [ ] URL changes should add a redirect to the old URL via https://github.com/Clic...
pamarcos opened a pull request on ClickHouse/clickhouse-docs
Minor improvement for Profiling with XRay
## Summary Minor improvement for Profiling with XRay ## Checklist - [ ] Delete items not relevant to your PR - [ ] URL changes should add a redirect to the old URL via https://github.com/Clic...
pamarcos created a branch on ClickHouse/clickhouse-docs
minor-improvements-to-profiling-with-xray - Official documentation for ClickHouse
pamarcos created a review comment on a pull request on ClickHouse/clickhouse-docs
Yep, I noticed that but I thought our markdown thingy on the web didn't support C++ syntax :sweat_smile: Will do, thanks for the tip
pamarcos pushed 3 commits to main ClickHouse/clickhouse-docs
pamarcos closed a pull request on ClickHouse/clickhouse-docs
Add Profiling ClickHouse with LLVM's XRay
## Summary Add Profiling ClickHouse with LLVM's XRay ## Checklist - [ ] Delete items not relevant to your PR - [ ] URL changes should add a redirect to the old URL via https://github.com/Clic...
pamarcos pushed 2 commits to 24.3 ClickHouse/ClickHouse
pamarcos closed a pull request on ClickHouse/ClickHouse
Fix bitShift test after backport
Fix bitShift test after backport Take the test from master, because it was not backported properly ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not requir...
pamarcos opened a pull request on ClickHouse/ClickHouse
Fix bitShift test after backport
Fix bitShift test after backport Take the test from master, because it was not backported properly ### Changelog category (leave one): - CI Fix or Improvement (changelog entry is not requir...