Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos created a review on a pull request on ClickHouse/ClickHouse
LGTM :+1: I verified that in https://s3.amazonaws.com/clickhouse-test-reports/71272/3a58012c33f9d73ffcfc14c4320b69c9a95272c6/ci_running.html we have the new stateful and 4 stateless tests for `aa...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
>this PR demotes the log level of unsuccessful authentication attempts from ERROR to DEBUG Isn't this demoting from ERROR to INFO, though? What's the rationale for this level as oppose to the on...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
@mstetsyuk could you please provide some context on why this is needed now?
pamarcos pushed 2 commits to 24.10 ClickHouse/ClickHouse
pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #71311 to 24.10: Fix debug log timestamp
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/71311 Cherry-pick pull-request #71316 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos closed a pull request on ClickHouse/ClickHouse
Fix debug log timestamp
Increase the error margin for the test to avoid flakiness in the intervals where the number of events is smaller. <!--- A technical comment, you are free to remove or leave it as it is when PR ...
pamarcos pushed 1 commit to minor-timestamp-fix-in-debug-log ClickHouse/ClickHouse
- Fix debug log timestamp Increase the error margin for the test to avoid flakiness in the intervals where the number ... cdb479d
pamarcos opened a pull request on ClickHouse/ClickHouse
Fix debug log timestamp
Increase the error margin for the test to avoid flakiness in the intervals where the number of events is smaller. <!--- A technical comment, you are free to remove or leave it as it is when PR ...
pamarcos created a branch on ClickHouse/ClickHouse
minor-timestamp-fix-in-debug-log - ClickHouse® is a real-time analytics DBMS
pamarcos pushed 2 commits to 24.10 ClickHouse/ClickHouse
pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #71124 to 24.10: Fix race condition in system.query_metric_log
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/71124 Cherry-pick pull-request #71264 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos pushed 2 commits to 24.10 ClickHouse/ClickHouse
pamarcos closed a pull request on ClickHouse/ClickHouse
Backport #71295 to 24.10: Improve system.query_metric_log to remove flakiness
Original pull-request https://github.com/ClickHouse/ClickHouse/pull/71295 Cherry-pick pull-request #71302 This pull-request is a last step of an automated backporting. Treat it as a standard pull-...
pamarcos closed a pull request on ClickHouse/ClickHouse
Improve system.query_metric_log to remove flakiness
- Use an interval of 400ms instead of 1234ms for the 2500ms sleep to avoid having a last collection that may clash with the finish one since 2500/1234=2.025. - Move the check for number of events ...
pamarcos opened a pull request on ClickHouse/ClickHouse
Improve system.query_metric_log to remove flakiness
- Use an interval of 400ms instead of 1234ms for the 2500ms sleep to avoid having a last collection that may clash with the finish one. - Move the check for number of events to a separate check. T...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
@Zawa-ll the reason why there are 0s after loading the primary keys is because you're using `round(primary_key_bytes_in_memory, -7)` as in my `03128_system_unload_primary_key`. However, both in my ...
pamarcos closed an issue on ClickHouse/ClickHouse
Stateless test `03203_system_query_metric_log` is flaky
It's failed in several places https://play.clickhouse.com/play?user=play#V0lUSAogICAgMzAgQVMgbGFzdF9kYXlzX3RvX2NoZWNrLAogICAgMTAwIEFTIG1heF90ZXN0c190b19zaG93LAogICAgNSBhcyBtYXhfcHJzX3RvX3Nob3csCi...
pamarcos closed a pull request on ClickHouse/ClickHouse
Fix race condition in system.query_metric_log
If a scheduled task was pending to lock the query_mutex, it could do so between the lock.unlock() and lock.lock() of finishQuery which is used to break the exec_mutex deadlock. In that case, a t...
pamarcos opened an issue on ClickHouse/ClickHouse
Stateless test `03203_system_query_metric_log` is flaky
It's failed in several places https://play.clickhouse.com/play?user=play#V0lUSAogICAgMzAgQVMgbGFzdF9kYXlzX3RvX2NoZWNrLAogICAgMTAwIEFTIG1heF90ZXN0c190b19zaG93LAogICAgNSBhcyBtYXhfcHJzX3RvX3Nob3csCi...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
I've checked the CI logs and everything seems fine. A few interesting cases that I thought were very unlikely but happen. Commenting them here for reference: ## Time jumps when using same query...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
Update: I've found that `NetworkReceiveBytes` can be inaccurate: https://github.com/ClickHouse/ClickHouse/blob/8246672945423065419baa02c5941dc91c67c3bf/src/IO/ReadBufferFromPocoSocket.cpp#L41 Tu...
pamarcos pushed 1 commit to hotfix_query_metric_log ClickHouse/ClickHouse
- Take into account that some profile events such as `NetworkReceiveBytes` are inaccurate 7a60543
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
I've found something weird happening on the CI, which is why I've added two new commits to try to clarify why it happens. A counter that didn't increase monotonically. Potential old value collec...