Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pamarcos opened a pull request on ClickHouse/ClickHouse
[Docs] Improve doc of globalVariable
Improve doc of globalVariable ### Changelog category (leave one): - Documentation (changelog entry is not required) ### Changelog entry (a user-readable short description of the changes that...
pamarcos created a branch on ClickHouse/ClickHouse
improve-global-variable-doc - ClickHouse® is a real-time analytics DBMS
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
> I'm not talking about saving the values at the start of the query (one extra row), but about not discarding the profileEvents that happened before start of query (typically from planning, which c...
pamarcos pushed 2 commits to system-query-metric-log pamarcos/ClickHouse
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Done at [`4223bb9` (#66532)](https://github.com/ClickHouse/ClickHouse/pull/66532/commits/4223bb95a50fde3155ae3d5f02eaf0a95a2e3ec4)
pamarcos pushed 1 commit to system-query-metric-log pamarcos/ClickHouse
- Add event at start of query Also remove the requirement to include events only for queries that take longer than col... 4223bb9
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
>I assume profileEvents are 0 at the very start of the query Yep, I double checked just in case and it's like that: https://github.com/ClickHouse/ClickHouse/blob/4baa30c06d7e7996c548b85120044ca6...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
>It seems that whatever events where triggered before calling QueryMetricLog::startQuery won't be part of any log (not even the first for the query), which is kind of unexpected That's right. `q...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
This should make it easier to understand: https://github.com/pamarcos/ClickHouse/blob/system-query-metric-log/tests/queries/0_stateless/03203_system_query_metric_log.reference ``` number_of_met...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Surprisingly, there was still a reference to something related to that header: https://github.com/pamarcos/ClickHouse/blob/f002e51a4e196423d7c85f4bd6ca0a68cb35a439/src/Interpreters/ProcessList.h#L4...
pamarcos created a review comment on a pull request on ClickHouse/ClickHouse
Yep, agree. I added it after the mutex on purpose to check the timestamp on the CI of where it was really collecting the log to check it was consistent with the table log. I'll move it before the l...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
> Are stress tests and fuzzers using the feature? If not, let's enable it. For stress / upgrade tests we probably can't since the config needs to be the same as for old features, but we can leave i...
pamarcos created a comment on an issue on ClickHouse/ClickHouse
Another one: https://s3.amazonaws.com/clickhouse-test-reports/66532/f002e51a4e196423d7c85f4bd6ca0a68cb35a439/stateless_tests__debug__s3_storage_.html ``` 2024-10-19 04:41:50 Reason: return code...
pamarcos pushed 109 commits to system-query-metric-log pamarcos/ClickHouse
- support readbigat on hdfs e93792a
- support prefetch 01673dd
- add prefetch test case 8faf2ea
- fix style 341f93d
- Use independent io thread pool 9ee1652
- fix ut 331872a
- add missing toIP functions c2d63df
- Merge branch 'master' into docs_toIP 515361a
- Merge remote-tracking branch 'origin/master' into parquet-prefetch # Conflicts: # src/Core/FormatFactorySettingsDecl... a1e38de
- Add exception message into "Hung check failed" message Here [1] the hung query failed: 2024.10.07 21:13:29.0446... 94df71f
- Kill tests leftovers in case of timeout Though now there are oddities with multiprocessing_manager.list(): Havi... 95f3d2e
- Ignore ESRCH while obtaining process group Should fix the following [1]: 2024-10-07 21:13:38 02784_connection_s... 9fd9ed4
- tests/clickhouse-test: fix pylint warning about unused vars in signal handler Signed-off-by: Azat Khuzhin <a.khuzhin... 5e33f2d
- review changes: change instances of value to string, add syntax and argument to toIPv4 fccd1cf
- Merge branch 'master' into docs_toIP 9bd36d2
- support min_bytes_for_seek 90f9d2d
- Remove indent 12ffb17
- Less log messages 6e9f7db
- add globalVariable function 0abb668
- update syntax 4be0d68
- and 89 more ...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
I ended up removing the low stddev check in the test at [`532d195` (#66532)](https://github.com/ClickHouse/ClickHouse/pull/66532/commits/532d1951b75deac25a9750e4414dd0777e2859e6) because it happene...
pamarcos pushed 1 commit to system-query-metric-log pamarcos/ClickHouse
- Remove stddev because the CI is far from deterministic The CI is often times overloaded and the background threads t... 532d195
pamarcos closed an issue on ClickHouse/clickhouse-docs
Document `globalVariable` function
Create documentation for the `globalVariable` function. See https://github.com/ClickHouse/clickhouse-docs/issues/1833 for details on how to complete this issue. Child issue of https://github.com...
pamarcos pushed 1 commit to docs_globalVariable Blargian/ClickHouse
- Add `globalVariable` to ignore dict 286610f
pamarcos pushed 397 commits to system-query-metric-log pamarcos/ClickHouse
- wip, fix hashing fb454a0
- shitty serialize impl, missing arrays 119f625
- wip 8966747
- undo something 6a7b087
- delete unnecessary stuff 0c368e5
- fix tests b080a94
- trigger ci 67b3241
- remove unused variable 7a6a60b
- progress c873e65
- style a9c3c10
- try to fix defines d6834bd
- add if use parquet 6d4fe75
- more complex test 2df232f
- update docs 49b1b55
- add new setting to settingshistory 03f812c
- Merge branch 'master' into add_parquet_bloom_filters_support b1ca8b2
- fix b20181a
- add suport for in check 8fec659
- add some tests for in cehck 335d499
- try chassert 558d5b0
- and 377 more ...
pamarcos created a comment on a pull request on ClickHouse/ClickHouse
@zvonand the test for LDAP is fixed through https://github.com/ClickHouse/ClickHouse/pull/70755 Please merge master and fix conflicts to give the CI another try