Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a comment on a pull request on endojs/endo
> In theory, old code could use `Proxy` in ways that this PR would break. But this is unlikely in general, and highly unlikely for any code in or depending on endo. Thus, practically, none. As d...
mhofman created a review on a pull request on Agoric/agoric-sdk
This made me realize a broader upgrade hazard which I've described in https://github.com/endojs/endo/pull/2675#pullrequestreview-2530812896
mhofman created a review on a pull request on Agoric/agoric-sdk
This made me realize a broader upgrade hazard which I've described in https://github.com/endojs/endo/pull/2679#pullrequestreview-2530808017
mhofman created a review on a pull request on Agoric/agoric-sdk
This made me realize a broader upgrade hazard which I've described in https://github.com/endojs/endo/pull/2679#pullrequestreview-2530808017
mhofman created a review on a pull request on endojs/endo
So I have 2 concerns after looking at this PR and its adoption in agoric-sdk (https://github.com/Agoric/agoric-sdk/pull/10795): - Given the early nature of the non-trapping proposal, I would like ...
mhofman created a review on a pull request on endojs/endo
So I have 2 concerns after looking at this PR and its adoption in agoric-sdk (https://github.com/Agoric/agoric-sdk/pull/10795): - Given the early nature of the non-trapping proposal, I would like ...
mhofman created a review comment on a pull request on endojs/endo
So thinking about this, unless we do something wrong inside ses itself, we should never trigger this for the `isNonTrapping` trap, right? And even if we did, it would be a safe failure.
mhofman created a review comment on a pull request on endojs/endo
I think this should get a TODO to be switched to both manually "non-trapping" instead of using `harden`.
mhofman created a review comment on a pull request on endojs/endo
Oh yeah I didn't think of that. That will potentially create a decent amount of churn on code that was manually freezing. It would be so much easier if frozen regular object would automatically pas...
mhofman created a review comment on a pull request on endojs/endo
```suggestion * because that would also harden `__proto__`. So we will need to ```
mhofman created a review comment on a pull request on endojs/endo
Ok I was confused at first, but this is a test that explicitly verifies that an object with a non-hardened proto is not passable. Can we make that more clear in the prelude of this comment?
mhofman created a review on a pull request on endojs/endo
Reading this and thinking through the implications, I have concerns we may be painting ourselves in a corner. Our recommendation is that one should harden values before passing them around. That im...
mhofman created a review on a pull request on endojs/endo
Reading this and thinking through the implications, I have concerns we may be painting ourselves in a corner. Our recommendation is that one should harden values before passing them around. That im...
mhofman created a comment on a pull request on Agoric/agoric-sdk
I believe an alternative we recently discussed is to do the serialization "locally" in a board library, and just send `slots` to the board vat.
mhofman created a comment on an issue on Agoric/agoric-sdk
I'm tempted to say we should not bother fixing this until we work on https://github.com/Agoric/agoric-sdk/issues/10799, especially if we disabled otel-trace in integration tests (https://github.com...
mhofman opened an issue on Agoric/agoric-sdk
Rework tracing slog sender
## What is the Problem Being Solved? We have an `otel-trace` slog sender which creates open telemetry traces by inferring relations between slog events. However it is fragile (https://github.com...
mhofman opened an issue on Agoric/agoric-sdk
Replace otel-trace with otel-context-aware-slog in integration test
## What is the Problem Being Solved? We don't currently use any of the otel tracing reporting (both because it's missing capabilities and because we no longer have a good frontend for it), and I...
mhofman opened an issue on Agoric/agoric-sdk
Classify trigger in contextualized slog sender
## What is the Problem Being Solved? The contextualized slog sender generates a high level trigger type based on the source of the inbound trigger (timer poll, bridge inbound, kernel update even...
mhofman created a comment on an issue on Agoric/agoric-sdk
I think something like this is needed for us to be able to run e2e integration tests on top of the simulated upgrade provided by agoric-sdk. My understanding right now is that nightly e2e tests onl...
mhofman created a comment on an issue on Agoric/agoric-sdk
We still have a remaining leak after the workaround for watchPromise: https://github.com/Agoric/agoric-sdk/issues/10794
mhofman opened an issue on Agoric/agoric-sdk
walletFactory heap is still growing after u18
## Describe the bug Investigating the wallet factory leak in u17 and before (#10706), we identified an issue (#10757) and implemented a workaround for it (#10756), however from preliminary obser...
mhofman created a comment on an issue on Agoric/causeway
In https://github.com/Agoric/agoric-private/issues/235#issuecomment-2569807154 I described some of the breadcrumbs I followed. I think the main aspect is being able to go from syscall send to send ...
mhofman created a review comment on a pull request on endojs/endo
I wouldn't expect anyone to know this, it's a very obscure quirk of `.bind()`
mhofman created a review comment on a pull request on endojs/endo
Maybe I missed something, but I still see this `shouldThrow` which I don't understand the purpose of. Why are we not throwing unconditionally here?
mhofman created a review comment on a pull request on endojs/endo
You do need to redefine `.name` if you want to keep the original `"Proxy"` name instead `"bound Proxy"`
mhofman created a review on a pull request on endojs/endo
Reopened the `shouldThrow` conversation as I don't see anything changed
mhofman created a review on a pull request on endojs/endo
Reopened the `shouldThrow` conversation as I don't see anything changed
mhofman pushed 1 commit to mhofman/ergonomic-exo-classes endojs/endo
- WIP: remove unneeded target prototype change 800d20d
mhofman created a review on a pull request on Agoric/agoric-3-proposals
I have [confirmed](https://github.com/Agoric/agoric-sdk/actions/runs/12571310964/job/35042085407#step:10:5884) the above. This hook should be sufficient to let us do anything needed.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
This works but FYI the preferred flow for manually testing integration between multiple repos for NPM packages is to generate a `yarn patch '@agoric/synthetic-chain'` and check the patch file in. ...