Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman closed a draft pull request on agoric-labs/cometbft
WIP revert
Test CI on a revert to eea8af3b5d9fe3aa923aaccd2884f8660206eda8 Mean to compare results to https://github.com/agoric-labs/cometbft/pull/14/checks
mhofman opened a draft pull request on agoric-labs/cometbft
WIP revert
Test CI on a revert to eea8af3b5d9fe3aa923aaccd2884f8660206eda8
mhofman closed a draft pull request on cometbft/cometbft
Test revert
Test CI on a revert to eea8af3b5d9fe3aa923aaccd2884f8660206eda8
mhofman opened a draft pull request on cometbft/cometbft
Test revert
Test CI on a revert to eea8af3b5d9fe3aa923aaccd2884f8660206eda8
mhofman created a branch on agoric-labs/cometbft
mhofman/revert-recent-changes - CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine
mhofman created a branch on agoric-labs/cometbft
fraz/bump-upload-artifact - CometBFT (fork of Tendermint Core): A distributed, Byzantine fault-tolerant, deterministic state machine replication engine
mhofman created a review comment on a pull request on Agoric/agoric-sdk
And we can't update these parameters outside of the core proposal, through a core eval or other governance vote, either before the upgrade, or after in the test?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think my core question was why these config have to be provided as core proposal argument, and cannot be stored in the config of the contract we're upgrading. That's what https://github.com/Agori...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I see configs for devnet and emerynet now, so satisfied.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Yeah you're right, a change in the proposal building would likely invalidate everything anyway, but collocating test files together is cleaner. I got confused about the `host` stuff however, I f...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I totally missed that here. We cannot use `snapshotStream` here but must use a stream provided as argument, which in the case of restartWorker would be `snapStoreSaveStream`, a tee of the original ...
mhofman created a review on a pull request on Agoric/agoric-sdk
Missed the snapshotStream bug. Thankfully our CI was screaming about it.
mhofman created a review on a pull request on Agoric/agoric-sdk
Missed the snapshotStream bug. Thankfully our CI was screaming about it.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I'm pretty sure that `stateDBDir` is unused if `slogSender` and `swingStore` are provided.
mhofman created a review on a pull request on Agoric/agoric-sdk
Thanks so much for rebasing and splitting that refactor commit. It's so much easier to follow now. Besides the minor feedback on the maybe lockdown file, this looks great! Feel free to merge onc...
mhofman created a review on a pull request on Agoric/agoric-sdk
Thanks so much for rebasing and splitting that refactor commit. It's so much easier to follow now. Besides the minor feedback on the maybe lockdown file, this looks great! Feel free to merge onc...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
The part that you're missing is that `'@endo/init/pre.js'` is mapped to `init/src/pre-node.js` on node through the `package.json` `exports`, which imports both `'./node-async_hooks-patch.js'` and `...
mhofman created a comment on an issue on Agoric/agoric-sdk
Assuming liveslots evolves to have durable promises, then it will be a valid pattern again to have unsettled promises across runs, and this problem will reoccur. Non durably handled promises would...
mhofman created a comment on an issue on Agoric/agoric-sdk
Related issue: https://github.com/Agoric/agoric-sdk/issues/10147#issuecomment-2644401358 Guest Promises / Host Vows should likely not be a bijection, but instead of N -> 1 weak mapping.
mhofman created a comment on an issue on Agoric/agoric-sdk
It dawns on me that our vow / guest promise handling may cause us to handle all guest promises, making unhandled promises in guest functions not report properly. This problem could be confused with...
mhofman created a comment on an issue on Agoric/agoric-sdk
I discussed this with @phoddie today, and the biggest difficulty to compare 2 snapshots is to be able to match the slots. When we write/read the snapshot from disk, the memory offsets change, so it...
mhofman created a comment on an issue on Agoric/agoric-sdk
@gibson042, I'm thinking we should review how the cosmic-swingset logs are handled too. The problem there is that some log calls are generated before we have a slogSender (known but undocumented is...
mhofman created a comment on an issue on Agoric/agoric-sdk
@michaelfig for testing considerations, we need to verify that an unhandled vow rejection would trigger a failed ava test.