Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Also the original `@endo/init` also tames async_hooks which this doesn't do. See https://github.com/endojs/endo/issues/2711
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Should the file's name capture this is doing an unsafe lockdown ?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Post-error parameter? Maybe multiple parameters of which the last is an error? Also what kind of node callback API does this!?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Sad, we can't even test if the intrinsics are frozen with unsafe harden.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I dislike changing the type of resolved values dynamically like that but I'll allow it here for backwards compat (and because I think the types get it). But I can't shake the feeling this is try...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I don't see how `savedChainSends` is initialized from the value returned by `launch`. Did that get dropped? The hangover logic is notoriously lacking testing and quite brittle (we have know bugs in...
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks like the beginning of some awesome test framework for cosmic-swingset. Pretty amazing! I am however concerned the hangover / savedChainSends logic got hurt in the refactor. (it was re...
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks like the beginning of some awesome test framework for cosmic-swingset. Pretty amazing! I am however concerned the hangover / savedChainSends logic got hurt in the refactor. (it was re...
mhofman pushed 2 commits to mhofman/fake-vstorage-blocks-2 Agoric/agoric-sdk
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oops, good thing the test I had updated caught that :p
mhofman pushed 2 commits to mhofman/fake-vstorage-blocks-2 Agoric/agoric-sdk
mhofman opened an issue on Agoric/agoric-sdk
Report breakdown timings of swingset execution
## What is the Problem Being Solved? While we're adding a high level timing metric for swingset execution per block (see #10960), we'd also like to understand better where our time is spent during...
mhofman opened a pull request on Agoric/agoric-sdk
Follow-up fake vstorage blockHeight advancement
refs: #10933 ## Description Forgot some test updates in the previous PR Also it was on automerge so I couldn't include @gibson042 's [review suggestion](https://github.com/Agoric/agoric-sdk/pu...
mhofman created a branch on Agoric/agoric-sdk
mhofman/fake-vstorage-blocks-2 - monorepo for the Agoric Javascript smart contract platform
mhofman created a comment on an issue on Agoric/agoric-sdk
We recently discussed this with @siarhei-agoric and @gibson042 and came up with the following additional requirement: - The piece of code doing the measurement may not itself produce the slog event...
mhofman opened an issue on Agoric/agoric-sdk
RunUtils / EV to not require settled promise
## What is the Problem Being Solved? [`RunUtils`](https://github.com/Agoric/agoric-sdk/blob/master/packages/SwingSet/tools/run-utils.js) and its helper `EV` are designed to swing SwingSet by injec...
mhofman created a comment on an issue on Agoric/agoric-sdk
Since I don't believe this these suites relies on the tests being sequential, I'd opt to keep the overall structure, and not transform them into a single test (which would lose a lot of the output ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I would have liked some JSDoc for these arguments. In particular documenting what the signature of invoker should be
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Technically the previous logic allowed `delivery` to be a promise that would get unwrapped, but I suppose no caller actually did that.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
To clarify, this relaxes `bundles` to allow extra props?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
To clarify, this makes `vats` required?
mhofman created a review on a pull request on Agoric/agoric-sdk
Sorry for the late review. Mostly some question (and a small nit)
mhofman created a review on a pull request on Agoric/agoric-sdk
Sorry for the late review. Mostly some question (and a small nit)
mhofman created a comment on an issue on tc39/proposal-immutable-arraybuffer
Actually it sounds like the check would be in [StructuredSerializeWithTransfer](https://html.spec.whatwg.org/#safe-passing-of-structured-data), which currently start as: > [For each](https://infra...
mhofman created a comment on an issue on tc39/proposal-immutable-arraybuffer
> (I suppose they could be transferrable and have that just do a copy, but that's kind of weird.) Given that transferable is an explicit opt-in from the sender, I don't think it makes sense to acc...
mhofman opened an issue on Agoric/agoric-sdk
Ability to report slog events from golang bridge
## What is the Problem Being Solved? We want to be able to capture some structured log events (slog) from golang cosmos modules that are executed while handling SwingSet bridge messages. For examp...
mhofman created a comment on an issue on Agoric/agoric-sdk
I filed https://github.com/Agoric/agoric-sdk/issues/10956 to investigate removing our reliance on variants altogether.
mhofman opened an issue on Agoric/agoric-sdk
Remove dependency on variants in proposal builders
## What is the Problem Being Solved? We've started to heavily rely on parametrized proposal builders, in particular accepting a variant for the deployed network, to encode chain specific config. T...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Actually they should be in `host`, and their core eval output should be in `test` Something like ```suggestion "host/testing/publish-test-info.js test/agoricNamesCoreEvals/publishTest...