Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
If this PR introduce a new proposal builder exercised in the upcoming upgrade, it should contain all config for all networks the upgrade could be deployed to.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
So I'll bite. Why do these config need to be hard coded in the builder? Can't they be restored from whatever params are currently on the respective chain, removing the need for variants?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
> I won't block on this, but we've been abusing `test.serial`. Its only guarantee is "not serial" and we've been relying on it being sequential. You mean "not concurrent". I honestly didn't real...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Looks like the comments needs formatting (weird indentation)
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think because `upgrade.go` somehow kept some u18 proposals around when it was rebased on top of u18.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Really unfortunate we still have the need for variants in this upgrade. We need to find a way out of this pickle, but I'm not gonna try to figure out why this upgrade needs special casing per netwo...
mhofman created a review on a pull request on Agoric/agoric-sdk
It's a little unfortunate we have more need for variants. But since that's already the case for the mintHolder I won't block on that.
mhofman created a review on a pull request on Agoric/agoric-sdk
It's a little unfortunate we have more need for variants. But since that's already the case for the mintHolder I won't block on that.
mhofman created a comment on an issue on Agoric/agoric-sdk
Assigning myself as I will do some heap investigation, possibly with @kriskowal looking over my shoulder
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh I didn't realize this was happening! I've been post-ponning updating my dev env... And we'll need to communicate this to validators.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I would feel more confident tagging a `v0.34.35-alpha.agoric.3`
mhofman created a review on a pull request on Agoric/agoric-sdk
LGTM, but please update the Documentation Considerations section Also I'll defer to you on the re-tagging of cometbft
mhofman created a review on a pull request on Agoric/agoric-sdk
LGTM, but please update the Documentation Considerations section Also I'll defer to you on the re-tagging of cometbft
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Missing ```suggestion uncompressedSizeDelta, restartWorker, ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
We should move this to the end of `saveSnapshot`. We need to keep track of the "current snapshot size" even if we don't restart the worker.
mhofman created a review on a pull request on Agoric/agoric-sdk
I love that we're moving the heap snapshot slogging in a single place. I think that if `restartWorker` is true, the delta will currently remain `null` (or stale) because we're never updating it ...
mhofman created a review on a pull request on Agoric/agoric-sdk
I love that we're moving the heap snapshot slogging in a single place. I think that if `restartWorker` is true, the delta will currently remain `null` (or stale) because we're never updating it ...
mhofman created a review comment on a pull request on Agoric/agoric-3-proposals
I never submitted this last week, but for future reference: > We can get the IP address from inside the container using something like `hostname -i` (trimming trailing space). We already need to...
mhofman created a review comment on a pull request on Agoric/agoric-3-proposals
Nit: ```suggestion const containerFilePath = '/root/host-test-message'; ```
mhofman created a review on a pull request on Agoric/agoric-3-proposals
Thanks for putting all this in. I second @turadg's request for cleaning up the commits before merging. This PR now does multiple things and I would prefer it not to be squashed, but interactively r...
mhofman created a review on a pull request on Agoric/agoric-3-proposals
Thanks for putting all this in. I second @turadg's request for cleaning up the commits before merging. This PR now does multiple things and I would prefer it not to be squashed, but interactively r...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Nit: I suspect this file is unnecessary
mhofman created a review on a pull request on Agoric/agoric-sdk
a3p needs to maintain an upgrade layer to the `unreleased` image so we can actually integration test this. Let's remove the variant names for this, it's not needed. I would prefer to do the c...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
We should not remove the `a:upgrade-18` layer entirely, but replace it with an `a:upgrade-18a` layer that has basically no tests of its own.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I'm surprised the `targetUpgrade string` is gone
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I don't even think we need any variant here
mhofman created a review on a pull request on Agoric/agoric-sdk
a3p needs to maintain an upgrade layer to the `unreleased` image so we can actually integration test this. Let's remove the variant names for this, it's not needed. I would prefer to do the c...
mhofman created a review on a pull request on Agoric/agoric-sdk
a3p needs to maintain an upgrade layer to the `unreleased` image so we can actually integration test this. Let's remove the variant names for this, it's not needed. I would prefer to do the c...