Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review on a pull request on Agoric/agoric-sdk
Satisfied that this show the hook works
mhofman created a review on a pull request on Agoric/agoric-sdk
Satisfied that this show the hook works
mhofman created a review comment on a pull request on endojs/endo
Not entirely true. Since we never care about the receiver in the case of a plain call, you could use `.bind(null)` which creates a function that lacks a `.prototype` but is constructible if the ori...
mhofman created a review comment on a pull request on endojs/endo
To avoid any potential collisions with trap methods, let's store the original handler as a unique symbol property on `handlerPlus`. After all that's what symbols were meant for :) ```js const O...
mhofman created a review on a pull request on endojs/endo
I've only reviewed the implementation so far. Looks good overall, except I don't understand this `shouldThrow` condition. Also a potential optimization: when adding a proxy to the `noTrappingSet...
mhofman created a review on a pull request on endojs/endo
I've only reviewed the implementation so far. Looks good overall, except I don't understand this `shouldThrow` condition. Also a potential optimization: when adding a proxy to the `noTrappingSet...
mhofman created a comment on a pull request on endojs/endo
> I have a feeling that we can prove an equivalent approach would be to store state on proxy objects only, since by definition ordinary objects can't be trapping. It was obviously too late for m...
mhofman created a review comment on a pull request on endojs/endo
Yeah I definitely considered suggesting either setting the object's trap as `undefined` or as the original Reflect function.
mhofman created a review comment on a pull request on endojs/endo
I thought about that but the main reason I suggested preinstalling traps is for performance reasons for engines that use a hidden class. I'm not sure how a proxy proto interacts with that, but in g...