Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman pushed 1 commit to mhofman/p2p-recv-msg-routine agoric-labs/cometbft
- Some more clarifications b3d807a
mhofman created a review comment on a pull request on agoric-labs/cometbft
I wanted to avoid changing the name of the original routine to keep future conflict resolution to a minimum, but maybe that's a misplaced hope
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks fine by me. Any reason it's still draft?
mhofman created a review comment on a pull request on agoric-labs/cometbft
The producer for this channel is `recvRoutine`. I admit we could be better at names here
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I would avoid mucking with the versions here, and leave the previously auto-incremented one even if it wasn't published.
mhofman pushed 2 commits to mhofman/pick-gov4-u18-change Agoric/agoric-sdk
mhofman opened a pull request on Agoric/agoric-sdk
Cherry-pick u18 branch a3p test change
refs: #10460 ## Description Cherry picks https://github.com/Agoric/agoric-sdk/pull/10460/commits/f0dca14997cf496c13390e4e229fe303642a795d back into master as that is the more correct test (addr...
mhofman created a branch on Agoric/agoric-sdk
mhofman/pick-gov4-u18-change - monorepo for the Agoric Javascript smart contract platform
mhofman created a comment on an issue on Agoric/agoric-sdk
Interesting. The main problem I see with that approach is that the caller needs to make sure they discard the object they assigned to `this.state`. I can think of mitigations (e.g. requiring that t...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh I'm ok with the proposal builder script keeping the hard coding, I was just saying it seems to already be using a proposal that is generic, not specific to orch-core.
mhofman created a comment on a pull request on Agoric/agoric-sdk
> I think we should instead just rely on the observable termination in this PR and the observed slow cleanup in prior testing. Do we have another vat to target in a3p to run the termination as a...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
That's an interesting filter + map pattern.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think I'd like this to fail if `targets.length === 0`.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
What is `scriptArgs.length === 0` ?
mhofman created a review on a pull request on Agoric/agoric-sdk
> The change to launch-chain should probably get more eyes. I don't know the invariants in that area and I see no relevant test changes. The changes to launch-chain are fine, they only affect sl...
mhofman created a review on a pull request on Agoric/agoric-sdk
> The change to launch-chain should probably get more eyes. I don't know the invariants in that area and I see no relevant test changes. The changes to launch-chain are fine, they only affect sl...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Yeah we usually go for the "variant" param being plumbed into the JS proposal builder. But I similarly don't care enough one way or the other, since it's simple enough here.
mhofman created a comment on an issue on Agoric/agoric-sdk
One thing not really captured here is what to do about instances that didn't use any state shape. Technically each of these instances could have different fields defined, and the behavior methods a...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
It looks like `upgrade-orch-core-proposal.js` really is a generic `upgrade-named-vats-proposal.js`, no ?
mhofman created a comment on an issue on Agoric/agoric-sdk
Now that https://github.com/Agoric/agoric-sdk/issues/10706 has a planned fixed for u18, this is no longer needed.