Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
We are missing the persisted context roughly always because the remaining beans is almost never 0.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I would to keep the order or these fields sane when a human (me) is reading the file in a terminal or editor with no line wrap. ```suggestion stream.write(serializeSlogObj({ ...rest, time }...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I sometimes dislike what types force us to do. The `finalBody.remainingBeans &&` part is totally unnecessary at runtime.
mhofman created a review on a pull request on Agoric/agoric-sdk
Conditionally approved given we reorder fields for easier human consumption.
mhofman created a review on a pull request on Agoric/agoric-sdk
Small question on eslint parser config, but besides that LGTM
mhofman created a review on a pull request on Agoric/agoric-sdk
Small question on eslint parser config, but besides that LGTM
mhofman created a comment on an issue on acornjs/acorn
You're right, acorn 8.0.5 includes a [change](https://github.com/acornjs/acorn/commit/6746b1905e1669a68738563ab23ade1c6a3b25be) that causes the `checkClashes` value to become a prototype-less objec...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
We're getting a lot of duplication because of this major bump. Any way to get rid of the v7 in any way? Looks like the only dependency is `eslint-plugin-github` whose [latest version](https://githu...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I suppose `latest` is not an option (aka the upgrade-18 packages are not up to date enough?)
mhofman created a review on a pull request on Agoric/agoric-sdk
Please consider bumping `eslint-plugin-github` to remove some new duplication of `typescript-eslint` packages
mhofman created a review on a pull request on Agoric/agoric-sdk
Please consider bumping `eslint-plugin-github` to remove some new duplication of `typescript-eslint` packages
mhofman opened an issue on endojs/endo
async_hooks fails obscurely when double initialized
## Describe the bug SES has double init checks to produce clear errors when trying to lockdown the environment twice. However it seems that when async_hooks taming is involved through `@endo/ini...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I just realized that in the final version the `> 0` part of the check was dropped, which causes the persisted context to always be empty.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Yeah I think having a single bidding denom is the assumption that wasn't clear to me.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
> ensure the brand is removed from the set, or we'll never try again to create a notifier. I have no problem with the ephemeral set being reset on error. My concern is with how the durable `upda...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
So there is never multiple bid brands for a given collateral? I'm just wary of assumptions like this that aren't super clear.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I just don't quite understand in which case this isn't already `null`. This is an error making the notifier, so afaiu we would never have updated this state in the first place?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I figured as much for the upgradability side, but I would prefer this to be written out as comment.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Why are we using the `collateralBrand` as key instead of the identity of this auctionBook? Are we guaranteed there is only ever a 1:1 relationship between auctionBook and collateralBrand?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Why is it necessary to reset the state here?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Can we explain why it's ok to have this be a heap Set? Both from a cardinality and upgradability pov.