Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review on a pull request on tc39/proposal-shadowrealm
Besides one minor correction, LGTM
mhofman created a review on a pull request on tc39/proposal-shadowrealm
Besides one minor correction, LGTM
mhofman created a comment on an issue on Agoric/causeway
With the new contextual slog sender in u18, we may want to enable search by trigger info (e.g. txHash)
mhofman created a comment on a pull request on tc39/proposal-shadowrealm
> the current proposed HTML integration defines the ShadowRealm global to behave _exactly_ like an ordinary object, but it's not an ordinary object. As I mentioned in #411, that's fine: > To ...
mhofman closed a pull request on Agoric/agoric-sdk
chore: upgrade-18 cherry-picks round 3
### Description Cherry-picks the following commit(s) from master: - https://github.com/Agoric/agoric-sdk/pull/10534 (https://github.com/Agoric/agoric-sdk/commit/8339df26533fd189dc576d92ed290...
mhofman reopened a pull request on Agoric/agoric-sdk
chore: upgrade-18 cherry-picks round 3
### Description Cherry-picks the following commit(s) from master: - https://github.com/Agoric/agoric-sdk/pull/10534 (https://github.com/Agoric/agoric-sdk/commit/8339df26533fd189dc576d92ed290...
mhofman created a comment on a pull request on tc39/proposal-shadowrealm
If this is something we can actually assert, that would work for me. In this case we should likely also assert that the object is extensible and that all own properties are configurable. I suppo...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I'm worried about maintenance. Is there any way to replicate the schema of the source db ?
mhofman created a review on a pull request on Agoric/agoric-sdk
Didn't go through the actual implementation yet, but I see a decent amount of duplication with statements that already exist in the swing-store package. Any reason not to move that tool there and r...
mhofman created a review on a pull request on Agoric/agoric-sdk
Didn't go through the actual implementation yet, but I see a decent amount of duplication with statements that already exist in the swing-store package. Any reason not to move that tool there and r...
mhofman created a comment on an issue on Agoric/agoric-sdk
Thought about this some more, and I think a single validator node + a loadgen follower started from state-sync and running with xsnap random init should be sufficient to test determinism regression...
mhofman created a comment on a pull request on Agoric/agoric-sdk
I'll be happy to re-review this once rebase on master and conflicts resolved.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
We need to add a new `lint-docs` required check on all protected branches, right?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Would it make sense to have a message a little more descriptive? maybe: ```suggestion [recLen17 - 3]: error('Error#3:', 'AsyncFlow1 definition site'), ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
would it read better as? ```suggestion 'during execution of flow', ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
while semantically equivalent to an `await eventLoopIteration()` followed by a call to `reject`, I assume this is written like this to put the rejection on an empty stack even if the engine has asy...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I would like to sanity check that the promise doesn't fulfill. ```suggestion const caughtP = p2.then( v => t.fail(`vow fulfilled with value ${v}`), e => { ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
why do we need this new crank?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think I'd like to see this test also written with a restart where the vow is only resolved in the new incarnation.
mhofman created a review on a pull request on Agoric/agoric-sdk
It was a little hard to digest the test. Wondering how we can simplify its reading.
mhofman created a review on a pull request on Agoric/agoric-sdk
It was a little hard to digest the test. Wondering how we can simplify its reading.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I am wondering if the ergonomics wouldn't be simpler with a wrapper for the original template tag function: ```js inlineArgs(X)`foo bar ${inlinedArg}`; ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Besides being an ephemeral store, I think we shouldn't burden ourselves with weak collections and their gc costs since we have delimited lifetimes for these host call entries, and don't need to ret...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Is there a reason to leave the host call in the map after rejection? I think doFulfill should remove from the map as well.
mhofman created a review on a pull request on Agoric/agoric-sdk
I still need to parse the test for this, but here are my preliminary comments on the implementation.
mhofman created a review on a pull request on Agoric/agoric-sdk
I still need to parse the test for this, but here are my preliminary comments on the implementation.