Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

mhofman

mhofman created a comment on a pull request on Agoric/agoric-sdk
> keep a durable weakMapStore from any result hostVow to the target, method, (and eventually, whether it is an "eventual" result). I have not reviewed yet, but I'm surprised we need a durable st...

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
`agoric-upgrade-18-reapply` ? But honestly we can keep as is too.

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
Given the passing tests in #10484, LGTM, but before merging I would like to see the `node ./addGov4` moved to `prepare.sh` to keep verifying in a3p-integration that we have indeed fixed the problem...

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
Given the passing tests in #10484, LGTM, but before merging I would like to see the `node ./addGov4` moved to `prepare.sh` to keep verifying in a3p-integration that we have indeed fixed the problem...

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
This looks functionally equivalent

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
This looks functionally equivalent

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
I still think we should change the signature of `getRequired` to be powerless and accept a `kvStore as argument. I don't like that we have multiple args that give you access to the kvStore. Probabl...

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
Right, `EncodeKVEntryReaderToJsonl` doesn't close the reader. I think that was because I wanted the reader to be closed even if a read error occurred, and leave the caller in charge of handling pot...

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's move these to `genesis.go` as it's only applicable to that logic.

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
Assuming my final nit is addressed, feel free to merge this. Thanks for working on this.

View on GitHub

mhofman created a comment on an issue on privatenumber/tsx
Possibly related to #442

View on GitHub

mhofman opened an issue on privatenumber/tsx
imported module evaluated as non-strict if importing module is not explicitly a module
### Acknowledgements - [X] I read the documentation and searched existing issues to avoid duplicates - [X] I understand this is a **bug tracker** and anything other than a proven bug will be close...
mhofman opened a pull request on Agoric/agoric-sdk
chore(smart-wallet): less noisy watch outcome
closes: #10513 ## Description Use `when` instead of `asPromise` in the smart-wallet offer outcome logic. Reduce noise on upgrades for disconnected promises which are not actually used for produ...
mhofman pushed 1 commit to mhofman/10513-noisy-smart-wallet-upgrades Agoric/agoric-sdk
  • chore(smart-wallet): less noisy watch outcome 0a227a7

View on GitHub

mhofman created a branch on Agoric/agoric-sdk

mhofman/10513-noisy-smart-wallet-upgrades - monorepo for the Agoric Javascript smart contract platform

mhofman opened an issue on Agoric/agoric-sdk
noisy smart-wallet upgrade because of disconnected outcome heap watcher
## What is the Problem Being Solved? To [support tests](https://github.com/Agoric/agoric-sdk/blob/5a4fc01b7f3226a5ad29eb1fd6a1c92cd25d4c5b/packages/smart-wallet/src/smartWallet.js#L986-L988), th...
mhofman created a comment on an issue on tc39/proposal-record-tuple
When talking about an immutable Map/Set there are 2 properties to consider given the semantics of Record/Tuple in this proposal: - the content of the collection is immutable - the collection can be...

View on GitHub

mhofman opened an issue on Agoric/agoric-sdk
Contract restart: v9-zoe
## What is the Problem Being Solved? Zoe seem to be experiencing a heap leak (issue TBD). Until we figure out where it's coming from, we need to restart Zoe periodically (each chain software upg...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I'm also wondering if we should bikeshed the name as it's not really like basic or meant to be applied on its own

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
While it doesn't change the behavior, we should have this new name return false in `isPrimaryUpgradeName`

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
Is there a draft PR where we can see a reapply of the upgrade on top of rc0 to verify it would fix emerynet?

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk
Is there a draft PR where we can see a reapply of the upgrade on top of rc0 to verify it would fix emerynet?

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

mhofman created a comment on an issue on Agoric/agoric-sdk
Chatting with @erights today, if we consider the other side of the problem (the decider not promptly resolving the promise), then the problem is more simple: report any unsettled promises by the ti...

View on GitHub

mhofman created a review comment on a pull request on Agoric/agoric-sdk
We definitely don't want to trigger swingset bootstrap for any genesis export, at least not without a manual intervention on the genesis file. And yeah it'd be the missing directory as the genesis ...

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

mhofman created a review on a pull request on Agoric/agoric-sdk

View on GitHub

Load more