Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Why not build type def files for this package? Wouldn't NPM consumers have problems with type checking when using it?
mhofman created a comment on an issue on Agoric/agoric-sdk
Related, we will likely want to make `M.await` be vow aware too (issue TBD), and figure out how `M.callWhen` and `M.asyncFlow` interact. (`M.callWhen(M.asyncFlow(M.await(Foo)))` ?)
mhofman opened an issue on Agoric/agoric-sdk
Support function as virtual/durable kinds
## What is the Problem Being Solved? Today `Far` accepts either a function or an object (with methods). However the same support for exportable functions is not extended to virtual / durable kin...
mhofman opened an issue on Agoric/agoric-sdk
Zones do not enforce redefinition of the same "kind"
## Describe the bug My memory is a little fuzzy on this, but I remember when looking at zones and how we were storing kind handles that there was the possibility that the user could define one k...
mhofman opened an issue on Agoric/agoric-sdk
Async-flow aware zone
## What is the Problem Being Solved? To support async flow exo methods (#9832) without liveslots support (#9881), we need to provide exo state access on top of the existing exo infrastructure. T...
mhofman opened an issue on Agoric/agoric-sdk
cosmic-swingset chain transcript and replay
## What is the Problem Being Solved? - Ability to replay swingset activity as a whole without requiring tendermint and cosmos. For example this can be useful in evaluating performance issues. -...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Part of this check is technically redundant ```suggestion if eventHandler.exportMode != keeper.SwingStoreArtifactModeDebug && eventHandler.snapshotHeight != provider.BlockHeight { ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
In the case of debug mode (and only in this case), the export artifact should capture the blockHeight of the swing-store, so we don't completely lose track of it (we unfortunately don't have a bett...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I very much would like to not change this as it matches [cosmic-swingset definitions](https://github.com/Agoric/agoric-sdk/blob/4b1403aa06a6c08aae2d4cce0fd582480b7e3c7f/packages/cosmic-swingset/src...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
It really is a bit unfortunate we have to read, decode, re-encode it all in memory before finally writing it out, but streamlining this is definitely out of scope.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
This should actually always be set, even in skip mode, to avoid triggering the ["bootstrap" logic from import genesis](https://github.com/Agoric/agoric-sdk/blob/4b1403aa06a6c08aae2d4cce0fd582480b7e...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
This should come from the swing-store export (aka `provider.GetExportDataReader()`).
mhofman created a review on a pull request on Agoric/agoric-sdk
Thanks for digging through this. The main issue is that we don't currently write out the "export data" as "untrusted copy" in debug mode, but instead we-write the cosmos DB copy.
mhofman created a review on a pull request on Agoric/agoric-sdk
Thanks for digging through this. The main issue is that we don't currently write out the "export data" as "untrusted copy" in debug mode, but instead we-write the cosmos DB copy.
mhofman created a comment on an issue on Agoric/agoric-sdk
https://github.com/Agoric/agoric-sdk/issues/10424 would add out of consensus instrumentation. Once this becomes part of consensus, we can consider letting some measurements made by xsnap affect sna...
mhofman created a review comment on a pull request on endojs/endo
Technically this can be simplified, no? ```suggestion ".": "./index.js", ```
mhofman opened an issue on Agoric/agoric-sdk
More xsnap instrumentation
## What is the Problem Being Solved? We need to figure out where we're spending time in xsnap, and be able to quickly compare timings of the same delivery between validators, or compare equivale...
mhofman created a comment on an issue on tc39/ecma262
> At least in the web platform, all objects are expected to be associated with a realm, so creating an object before the realm exists is somewhat inconvenient. I'm surprised. I thought engines wer...
mhofman created a comment on a pull request on tc39/proposal-async-context
> I am fine with the restriction to ignore all but non-wellknown symbols as keys. I think there's still a misunderstanding somewhere. To prevent observable mutable global state, the only kinds o...
mhofman created a review comment on a pull request on endojs/endo
I still see the specifiers here using `.ts`
mhofman created a review comment on a pull request on endojs/endo
This seems like a superset of `../types-index.d.ts`. Should we look into making that explicit somehow by having the internal file reexport the external file? (they would likely have to be moved aro...
mhofman created a review comment on a pull request on endojs/endo
So we're positive all internal usages of `types.js` are through type imports and never runtime imports?
mhofman created a review comment on a pull request on endojs/endo
This seems like a duplicate of `types-index.d.ts`. How do you propose to keep them in sync under maintenance? I'm actually wondering if this file shouldn't just go away given that we export type...
mhofman created a review on a pull request on endojs/endo
I only reviewed the organization of the type files.
mhofman created a review on a pull request on endojs/endo
I only reviewed the organization of the type files.
mhofman created a review comment on a pull request on endojs/endo
The only thing I can think of is to catch the error and annotate it. But yes regardless the behavior is correct.