Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Perfect, we can rely on their `forceFlush`. Well their `Promise.all` swallows multiple errors, but that's a common mistake people make, and it's good enough in this case.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
It doesn't look like that method is bound. ```suggestion forceFlush: () => otelLogExporter.forceFlush(), ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's avoid promise chaining. Also these methods of otel don't seem bound. There is probably a cleaner way, but the following should work: ```suggestion shutdown: async () => { const...
mhofman pushed 11 commits to mhofman/telemetry-fixes Agoric/agoric-sdk
- chore(acceptance): add tests for PSM to `z:acceptance` Refs: https://github.com/Agoric/BytePitchPartnerEng/issues/23... b632a6f
- chore(sync-tools): improve types 501c138
- chore(psm-acceptance): address change requests and apply sync tools Refs: https://github.com/Agoric/BytePitchPartner... 11b336b
- chore(acceptance): add tests for PSM to `z:acceptance` (#10273) closes: https://github.com/Agoric/BytePitchPartnerEn... 2ede8c1
- fix(internal): better stream error handling 1ea3f06
- fix(telemetry): silence slogfile write errors They'll be reported on flush 91089d7
- fix(telemetry): avoid polluting stdout in ingest-slog d4b8dfa
- feat(internal): fs stream to stdout b4af829
- feat(telemetry): ingest-slog explicitly supports `-` for stdin 63367c4
- fix(telemetry): ingest-slog avoid writing progress file for stdin 62589ca
- feat(telemetry): ingest-slog throttle and flush per block 2134944
mhofman pushed 1 commit to mhofman/telemetry-fixes Agoric/agoric-sdk
- fixup! feat(internal): fs stream to stdout 53a94d4
mhofman pushed 3 commits to mhofman/telemetry-fixes Agoric/agoric-sdk
mhofman created a review comment on a pull request on Agoric/agoric-sdk
The args are already local, but yeah, I can do that.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Now I understand why your eyes were on that PR!
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Wondering if we can adapt the async-flow eslint rule to prevent these closures from using their surrounding scope.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Out of curiosity, why not ```suggestion t.not( initialEntries.size, 0, ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Should this set a `defaultReapInterval`?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Wondering if types could somehow have helped discover this one.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh this one is a can of worms from what I recall. Some tools/tests pass different things in here. Types only so it may be fine, but there's no guarantee it might not blow up in the future.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
That looks like a dup ```suggestion ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
You likely want to default on the `highPriorityQueue`, that's what we do on the cosmos side.
mhofman created a review on a pull request on Agoric/agoric-sdk
This is a pretty incredible change to enable testing of cosmic-swingset behavior. Hopefully starts paving the path for more tests. Some of these changes feel reminiscent of https://github.com/Ag...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Also I had used string concatenation in this case because from recollection it's more performant, and this is a fairly hot path.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I just realized we shouldn't return the result of `logger.emit` because the `slogSender` result is not handled. Do you know if any previous error is rolled into the processor's flush? If not we ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Please restore the `catch` and don't return the promise (`slogSender` is called without any await). I want to avoid unhandled rejections when `write` fails (since those are rolled into the `flush` ...
mhofman created a review on a pull request on Agoric/agoric-sdk
I forgot about the return value of `slogSender`. Let's make sure we don't end up with unhandled rejections.
mhofman created a review on a pull request on Agoric/agoric-sdk
I forgot about the return value of `slogSender`. Let's make sure we don't end up with unhandled rejections.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
> Even if `fractionStr` returns a length greater than 9, padding would have no effect so wouldn't we will be slicing on `fractionStr` indirectly? Fair. For some reason it feels more confusing to...
mhofman opened a pull request on Agoric/agoric-sdk
Telemetry fixes
refs: #10300 Incidental Best reviewed commit-by-commit ## Description While verifying #10300 I ran into some errors and lack of stdout streaming features. This is what I arrived at to l...
mhofman created a branch on Agoric/agoric-sdk
mhofman/telemetry-fixes - monorepo for the Agoric Javascript smart contract platform
mhofman created a review comment on a pull request on Agoric/agoric-sdk
so is this ```suggestion return console.error( ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
```suggestion * @import {MakeSlogSenderOptions as Options} from './index.js' ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's avoid polluting stdout ```suggestion console.warn(`Using file ${filePath} for slogger context`); ```