Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
This is actually an error ```suggestion console.error('Error reading context from file: ', parseErr); ```
mhofman created a review on a pull request on Agoric/agoric-sdk
I have verified that the processor seem to generate coherent context data. Once the slicing of timestamp fraction is fixed, feel free to merge. Also consider adding a `context-aware-slog-file...
mhofman created a review on a pull request on Agoric/agoric-sdk
I have verified that the processor seem to generate coherent context data. Once the slicing of timestamp fraction is fixed, feel free to merge. Also consider adding a `context-aware-slog-file...
mhofman opened an issue on Agoric/agoric-sdk
Software upgrade core proposal bundle install interleaves with remaining work
## Describe the bug Support for core proposals during software upgrade ends up generating and installing bundle while processing the init message. A side effect of bundle installation is to queu...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
That is a pretty severe leak. Do we have an issue?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Does that mean that anything ever provided to a device never gets collected?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Of couse we should see a 1 adjustment, I just wish it was limited to a single "base" line, and every other line wouldn't require a change.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
> doing `kunser()` twice on the same capdata will give you two different psuedo-Presences Oh that's surprising for presences
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Sorry I meant should this "also" return the marker, so that the test file can compare the identities.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
The slicing should be done on `fractionStr`, not the result of the padding.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
descriptions change that wasn't included in a previous fix?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I wish a lot of these numbers were expressed as relative offsets to avoid requiring so made "by 1" adjustments.
mhofman created a review on a pull request on Agoric/agoric-sdk
The core logic looks good. Since promises are in fact valid in vatParameters, I'd like to test them.
mhofman created a review on a pull request on Agoric/agoric-sdk
The core logic looks good. Since promises are in fact valid in vatParameters, I'd like to test them.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
To be clear, these eventual sends also result in imported / externally decided promises but since they're immediately settled, they do not participate in any cleanup?
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks fairly straightforward. The tests do seem very descriptive, which I'm worried will complicate maintenance, but that's out of scope for this change.
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks fairly straightforward. The tests do seem very descriptive, which I'm worried will complicate maintenance, but that's out of scope for this change.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh yeah classic generic silliness
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Precision of the source data doesn't mean anything for the representation as an IEEE 754 number. Those tend to do weird things often enough that I wouldn't bet on there being a max of 9 digits when...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
There should be a trigger context by this point. Let's add an assertion
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I'm confused, I'm suggesting only passing `kvStore` here, and refactoring `getRequired` to be pure and thus importable. Of course that's a fairly decent refactoring, so arguably out of scope at thi...