Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Should we check the intermediate state before events are injected?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Check that `modified` is true ? ```suggestion const { modified } = upgradeSwingset(kernelStorage); t.true(modified); ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
This copy paste probably needs a tweak?
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Now that #10337 merged into this one, let's revert this `addToQueue` change. I really don't like the stats boundary piercing.
mhofman created a review on a pull request on Agoric/agoric-sdk
Overall LGTM. Feel free to merge once the revert of `addToQueue` and the test tweaks are done.
mhofman created a review on a pull request on Agoric/agoric-sdk
Overall LGTM. Feel free to merge once the revert of `addToQueue` and the test tweaks are done.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Actually I think we can persist an empty context instead (so you can keep `null` as missing). ```suggestion persistContext(finalBody.remainingBeans > 0 ? {} : triggerContext); ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh I missed the typo here! ```suggestion FINISH: 'crank-finish', ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think we need to reset the context on finish for the reporting of the finish event, or it gets some leftover delivery details. Also let's include the vatID here. ```suggestion case ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's set the bootstrap trigger context here. ```suggestion } case SLOG_TYPES.COSMIC_SWINGSET.BOOTSTRAP_BLOCK.START: { triggerContext = { 'run.num': undefined, ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's move this after reporting ```suggestion ```
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Now that we're gonna persist `null` values as context, I think we should differentiate uninitialized (`undefined`) from `null` contexts (and of course let the initial value of the context be `undef...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I forgot that this would transiently show up in the output for this event. `undefined` will make it be skipped while still reserving the position. ```suggestion 'run.num': undefined, ...
mhofman created a review on a pull request on Agoric/agoric-sdk
Well I knew I wouldn't get it right just by staring at the code generating slog events. After looking at the output, looks like we have some tweaks to make.
mhofman created a review on a pull request on Agoric/agoric-sdk
Well I knew I wouldn't get it right just by staring at the code generating slog events. After looking at the output, looks like we have some tweaks to make.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Well this is actually more of a "makeOnce" store pattern than a memoization, where we can just throw away the store after usage.
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks good, but holding my approval until I review the output of aa processed slog in case I missed anything. Is the grafana link up top still valid? I'll also look at the processed slog file ...
mhofman created a review on a pull request on Agoric/agoric-sdk
This looks good, but holding my approval until I review the output of aa processed slog in case I missed anything. Is the grafana link up top still valid? I'll also look at the processed slog file ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Oh I didn't know we had a memoize in internal now.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Well, device output embargo should be until after commit of the storage.
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's make sure we don't imply that the host must commit after a single call to run. The host is free to perform multiple runs between commits if it so wishes. The only condition is that commit not...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
I think we should generalize the devices not just to transmission but to effects. ```suggestion SwingSet provides robust and deterministic computation, even in the face of unexpected reboot, an...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
Let's make sure this only happens in consensus restarts ```suggestion if (upgradeEvents) { isBootstrap || upgradeDetails || Fail`Unexpected upgrade ...
mhofman created a review comment on a pull request on Agoric/agoric-sdk
```suggestion const context = { blockHeight, txHash, msgIdx: 0 }; ```
mhofman created a review on a pull request on Agoric/agoric-sdk
That launch-chain integration looks pretty good!