chunhtai opened a pull request on flutter/flutter
Fixes keyboard selects disabled radio
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github....
chunhtai created a comment on an issue on flutter/flutter
You could use different type to differentiate different group ```dart RadioGroup<String>( child: RadioGroup<int>( child: CustomScrollView(...) ) ) ```
chunhtai created a comment on a pull request on flutter/flutter
This is their code, are we overriding the disable style somehow? ```dart final style = buttonStyle ?? TextButton.styleFrom( foregroundColor: theme.colors.primary, ...
chunhtai created a comment on a pull request on flutter/flutter
before <img width="345" height="155" alt="image" src="https://github.com/user-attachments/assets/172e239b-37f3-4eab-b10e-2892b8154dfb" /> after <img width="277" height="99" alt="image" src="htt...
chunhtai created a comment on a pull request on flutter/flutter
I saw a button that was previous disabled but becomes enabled, maybe some of the enabling or onpress callback is not wire up correctly?
chunhtai created a comment on an issue on dart-lang/sdk
I also don't think we should go with this. Sometimes which build context is important. ```dart Widget _myBuilder(BuildContext context) { if (TickerMode.of(context)) { return ImplicitAnimat...
chunhtai created a review comment on a pull request on flutter/flutter
Can this be focusable but not enabled?
chunhtai created a review comment on a pull request on flutter/flutter
also set expandable? or is this already set by menuAnchor?
chunhtai created a review comment on a pull request on flutter/flutter
some platform may still treat this as textfield if both istextField and isButton are true.
chunhtai created a review comment on a pull request on flutter/flutter
> MediaQueryData.disableAnimations is related to the system accessibility setting Yes, but what if a user toggle this setting and see all the animation is still animating. That feels bad. Right ...
chunhtai created a review comment on a pull request on flutter/flutter
What if image source changes?
chunhtai opened a pull request on flutter/flutter
iOS can set application locale before view controller is set
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github....
chunhtai created a comment on an issue on flutter/flutter
What is the relationship between iOS Engine, engine shell, and view controller? I thought iOS engine will create both view controller and engine shell so this assertion should not be null I think?
chunhtai created a comment on an issue on flutter/flutter
For individual a11y issues, we are working hard on fixing them. it is an ongoing effort, Things like https://github.com/flutter/flutter/issues/173097, https://github.com/flutter/flutter/issues/9960...
chunhtai opened an issue on flutter/flutter
[batch-release] A github action for parsing unreleased commit and produce release PR
main doc: flutter.dev/go/batch-release-one-pager We need a bot to parse unreleased yaml file and produce a release pr.
chunhtai created a review comment on a pull request on flutter/flutter
you may need to update `flutter update-packages`
chunhtai created a review comment on a pull request on flutter/flutter
looking at the code this `_icon` is just to check whether a padding is needed. The developer are still expect to build an icon in the child by themselves. might as well let this be `bool addPadddi...
chunhtai created a review comment on a pull request on flutter/flutter
We can consider make this a regular constructor so you don't need to pass "addPaddding" information through the default constructor. ```dart const OutlinedButton({ ... }) : _addPadding = false; ...
chunhtai created a review comment on a pull request on flutter/flutter
we should use a more general comment and not assuming this is a result of overlay portal
chunhtai created a review comment on a pull request on flutter/flutter
when do we clean up the _traversalChildNodes and _traversalParentNodes when nodes in it are disposed
chunhtai created a review comment on a pull request on flutter/flutter
We also need to update the SemanticsConfiguration.absorb
chunhtai created a comment on an issue on flutter/flutter
This should be fixed by https://github.com/flutter/flutter/pull/173005, cc @QuncCccccc