chunhtai created a comment on a pull request on flutter/flutter
Hi @mdebbar should i close this pr instead?
chunhtai opened a pull request on flutter/flutter
Update README.md
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github....
chunhtai created a branch on flutter/flutter
chunhtai-patch-1 - Flutter makes it easy and fast to build beautiful apps for mobile and beyond
chunhtai pushed 10000 commits to issues/157824 chunhtai/flutter
- Roll Skia from 1e9afcd7dda6 to 38e2598c487b (1 revision) (flutter/engine#55737) https://skia.googlesource.com/skia.g... 8a01448
- Roll Skia from 38e2598c487b to 857248fe0a9a (3 revisions) (flutter/engine#55741) https://skia.googlesource.com/skia.... e583fec
- Record notes on hashing artifacts in a monorepo (flutter/engine#55703) aka "dude, where's my engine?" 35d7b1b
- added shell_unittests and ui_unittests to the testing menu (flutter/engine#55711) ## Pre-launch Checklist - [x] I... 96134c8
- [Impeller] remove heap allocation of most geometry objects. (flutter/engine#55677) Almost all geometry objects can n... 32aa606
- Roll Skia from 857248fe0a9a to 8a2fe88d31e3 (7 revisions) (flutter/engine#55749) https://skia.googlesource.com/skia.... d75cffe
- Added mutex to the pending gpu tasks deque. (flutter/engine#55748) b/371513051 The tasks are already capturing th... d2e73ae
- [Impeller] libImpeller: Allow wrapping external texture handles. (flutter/engine#55664) Fixes https://github.com/flu... 7af6ae8
- [Impeller] libImpeller: Fix typo in public API. (flutter/engine#55750) cc @lyceel 50366d3
- Roll Skia from 8a2fe88d31e3 to 701b6e4b4bc4 (1 revision) (flutter/engine#55752) https://skia.googlesource.com/skia.g... f15530a
- Added support to set primitive type (flutter/engine#55514) Added a way to specify the PrimitiveType when encoding co... a01daf5
- [Impeller] Do not scale the miter limit applied to stroked text (flutter/engine#55745) Fixes https://github.com/flut... d8d3d6a
- fixes mask blurs on stoked gradient geometry (flutter/engine#55717) fixes https://github.com/flutter/flutter/issues/... 90cea20
- Refactor multi-file build parsing into a single `BuildPlan` class. (flutter/engine#55720) Closes https://github.com/... 173af3d
- [canvaskit] Fix incorrect clipping with Opacity scene layer (flutter/engine#55751) Fixes opacity layer incorrectly c... 0ed3937
- [Flutter GPU] Get the GLES backend/Windows working. (flutter/engine#55694) Resolves https://github.com/flutter/flutt... e118869
- Release`onTrimMemoryListener` after `ImageReaderSurfaceProducer` released. (flutter/engine#55760) Fixes https://gith... 8e3b58f
- Roll Skia from 701b6e4b4bc4 to a077e78e531f (3 revisions) (flutter/engine#55761) https://skia.googlesource.com/skia.... 93d88f8
- Roll Fuchsia Test Scripts from jCde9sMKJ3YAdG2DH... to _fkA2GjLQH4bc_n2p... (flutter/engine#55762) If this roll has ... b1c6343
- [Impeller] libImpeller: Allow fetching OpenGL texture handle. (flutter/engine#55753) Fixes https://github.com/flutte... 511ee36
- and 9980 more ...
chunhtai created a review comment on a pull request on flutter/engine
I will do that in a separate pr when i add the support to the desktop embedding. I am trying to avoid adding support for all platforms in a single pr
chunhtai created a review comment on a pull request on flutter/packages
why would this throw? I thought we allow redirect to the same route, which go_router treats it as no redirect.
chunhtai created a review comment on a pull request on flutter/packages
This comment seems inaccurate
chunhtai created a review comment on a pull request on flutter/flutter
this doesn't look right shouldn't this be ```dart reverseCurve = toHero.widget.reverseCurve ?? toHero.widget.curve.flipped; ``` same for line 484
chunhtai created a comment on an issue on flutter/flutter
I am not sure what Android package you are referring to. but it looks like it is appium's android inspector treated resource name of textfield differently than other view
chunhtai created a comment on an issue on flutter/flutter
Looks like the NSAccessibilityCustomAction is not hooked up in macos
chunhtai closed an issue on flutter/flutter
a11y focus problem with DropdownMenuItems and BottomNavigationBar
Internal: b/143551289 With a widget tree like: ``` Scaffold Navigator --> DropdownButton ... BottomNavigationBar ``` Open the dropdown's popup and navigate between the DropdownMenuIt...
chunhtai closed an issue on flutter/flutter
Disabled text field should contribute semantics
```dart import 'package:flutter/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return Materia...
chunhtai created a comment on an issue on flutter/flutter
Need to verify the native behavior, but it seems like jumping to a random botton on the screen after keyboard close is not good.
chunhtai created a comment on an issue on flutter/flutter
This seems like a appium bug to me, flutter uses setViewIdResourceName to set the id. it would be appium to display it correctly
chunhtai closed an issue on flutter/flutter
TextField Accessibility ID not persist in Android but exist in iOS
### Steps to reproduce 1. build a sample app with one `TextField` and one `TextButton` 2. runApp 3. use `appium` to check Accessibility ID exist or not ### Expected results TextField and TextB...
chunhtai created a comment on a pull request on flutter/packages
Hi @ValentinVignal , are you still working on this pr?
chunhtai created a comment on an issue on flutter/flutter
This is due to the push will only be registered in navigator until next frame. An immediate pop in the same frame will not be able to pop the newly push route. This is something we should fix
chunhtai created a review comment on a pull request on flutter/flutter
the debugTransitionFinished sounds good to me