Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

asanchezr

asanchezr pushed 2 commits to psp-9683-h120-electoral-district-bug asanchezr/PSP
  • PSP-9760 : FT:Projects: User is not able to update any of the project details after user adds the Project Team member... 1bc3755
  • CI: Bump version to v5.7.0-96.21 ba2043b

View on GitHub

asanchezr pushed 2 commits to psp-9683-h120-electoral-district-bug asanchezr/PSP
  • Psp 9512 - corrections/enhancements (#4562) * reduce round trips to database, add capability for database to retry t... 5bf92e9
  • CI: Bump version to v5.7.0-96.20 2981f65

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a branch on asanchezr/PSP

psp-9683-h120-electoral-district-bug - Property Services Project

asanchezr pushed 22 commits to dev asanchezr/PSP
  • PSP-9471 fix 63df019
  • PSP-9471 unit test 7c580e6
  • updates eef09b5
  • Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471 1f6c9bf
  • update unit tests 18d9c21
  • Merge branch 'dev' into PSP-9471 914c15e
  • Deleting unneccesary imports 24572ab
  • Deleting unneccesary imports 991b36d
  • Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471 acb5b41
  • Merge branch 'dev' into PSP-9471 7f3641e
  • Merge branch 'bcgov:dev' into PSP-9471 a51985c
  • Adding logic on organizations to cover changes on status field 799ada0
  • Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471 e06fc4c
  • Merge branch 'bcgov:dev' into PSP-9471 350ae84
  • changes on organization and person status logic c49de85
  • Merge branch 'PSP-9471' of https://github.com/stairaku/PSP into PSP-9471 b5b7326
  • Changes on contact models to convert isDisabled to string from Api to Form ce0c73f
  • Changes on contact models to convert isDisabled to string from Api to Form 6da46e7
  • Merge pull request #4552 from stairaku/PSP-9471 PSP-9471: UI UX Clean Up - Contact – Manage Contacts: Allow to save ... 102f2f4
  • CI: Bump version to v5.7.0-96.18 31b1e80
  • and 2 more ...

View on GitHub

asanchezr created a branch on asanchezr/PSP

psp-9416-subdivided-property-prevent-deletion - Property Services Project

asanchezr pushed 1 commit to dev bcgov/PSP
  • Psp 9763 - infinite render loop (#4561) * fix infinite render loop caused by hasClaim function. * formatting fixes. 80f9198

View on GitHub

asanchezr closed a pull request on bcgov/PSP
Psp 9763 - infinite render loop
asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 6 commits to dev asanchezr/PSP
  • psp-9256 allow users added to a project to view an acquisition file. (#4555) * psp-9256 allow users added to a proje... c3a630e
  • CI: Bump version to v5.7.0-96.15 ae14501
  • Address race condition where: (see comment) (#4559) * Address race condition where: 1) (thread #1) upload document ... 5bc754c
  • CI: Bump version to v5.7.0-96.16 d6c46e4
  • PSP-9604 : Acquisition file- Progress statuses (#4554) Co-authored-by: Herrera <[email protected]> Co-au... c262323
  • CI: Bump version to v5.7.0-96.17 a084d97

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
Please see comments

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
same comment here re: checking for the string representation value

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
if you follow the pattern I described in my other comment, then here you would only need to check for the string "false"

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
This field should **always** be string. Yes, it will contain string values of "true" or "false" but those are string representations of boolean values. We need this field to be a string because it ...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
This is because Formik values for dropdowns (SELECT input field) are always strings. We have several utility methods to convert from "stringy" booleans to "real" booleans

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 16 commits to dev asanchezr/PSP
  • Add alter ups to change the name of the PIMS_ROLEs for lease/license (#4545) * Add alter ups to change the name of t... 738a3c1
  • CI: Bump version to v5.7.0-96.7 439c27f
  • PSP-9743 Generate green button in the Expropriation tab for Form 1,5 and 9 are displaying incorrect colour (#4549) *... 0f8b808
  • CI: Bump version to v5.7.0-96.8 7bf12a9
  • PSP-9570 Property Information leaflet should open up when a property is part of the PIMS Inventory regardless if it h... 4a5b20b
  • CI: Bump version to v5.7.0-96.9 77c659a
  • PSP-9513 : Change document workflow - support asynchronous upload (#4535) * PSP-9513 : Change document workflow - su... 89ca6cd
  • CI: Bump version to v5.7.0-96.10 26d1ff5
  • Psp 9512 jobs for upload, polling, retries (#4529) * psp-9500 scheduler microservice. * psp-9512 tests and jobs f... dfc2b6a
  • CI: Bump version to v5.7.0-96.11 b71844e
  • correct error when filtering by file #. (#4557) * correct error when filtering by file #. * sort logic correction. fefd57c
  • CI: Bump version to v5.7.0-96.12 94fedbc
  • remove retired check from research files. (#4556) 98b50db
  • CI: Bump version to v5.7.0-96.13 79d7389
  • PSP-9572 : Acquisition- Aggregating and Displaying Final H-120 CompeNsation Requisition Totals for Linked Files (#455... 5c73dcc
  • CI: Bump version to v5.7.0-96.14 11bb53f

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
thanks for doing this!

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
Not to do this now - but this could would benefit from a `Promise.all(...)` approach to fetch the related entities. Right now we wait for each request to complete in sequence. Putting a TODO commen...

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
question - I believe our pattern when we map models into EF entities is that we keep the ID but do not map child entities to avoid accidental updates to the children - right? I see here that we ...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 13 commits to psp-9256 devinleighsmith/PSP
  • PSP-9743 Generate green button in the Expropriation tab for Form 1,5 and 9 are displaying incorrect colour (#4549) *... 0f8b808
  • CI: Bump version to v5.7.0-96.8 7bf12a9
  • PSP-9570 Property Information leaflet should open up when a property is part of the PIMS Inventory regardless if it h... 4a5b20b
  • CI: Bump version to v5.7.0-96.9 77c659a
  • PSP-9513 : Change document workflow - support asynchronous upload (#4535) * PSP-9513 : Change document workflow - su... 89ca6cd
  • CI: Bump version to v5.7.0-96.10 26d1ff5
  • Psp 9512 jobs for upload, polling, retries (#4529) * psp-9500 scheduler microservice. * psp-9512 tests and jobs f... dfc2b6a
  • CI: Bump version to v5.7.0-96.11 b71844e
  • correct error when filtering by file #. (#4557) * correct error when filtering by file #. * sort logic correction. fefd57c
  • CI: Bump version to v5.7.0-96.12 94fedbc
  • remove retired check from research files. (#4556) 98b50db
  • CI: Bump version to v5.7.0-96.13 79d7389
  • Merge branch 'dev' into psp-9256 2131555

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
general question about permissions - I see all queue endpoints require sysadmin permissions. Is this intended? How will the frontend connect to this new API for non-admin users?

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

Load more