Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

asanchezr

asanchezr created a review on a pull request on bcgov/PSP
See comments

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
**nit:** this file doesn't seem exclusive to compensations - would prefer to see this moved to a common folder instead of being under compensations folder

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
on other components we show a tooltip that they cannot "Add" but I don't see it here. Just confirming this is expected or whether the tooltip should be displayed here...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
See comments regarding icon sizing

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
same comment re: inconsistent sizing

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
same comment re: inconsistent sizing

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
same comment re: inconsistent sizing

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
I see inconsistent sizing of these icons. Sometimes no size is specified, sometimes we set it to "2.6rem" and here we set it to "2.8rem" - can you confirm that Anna approved these differences?

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
wouldn't it make sense to specify the width and height = "2.6rem" here like you did with the other icon below? That way if the original icon is modified in size, this would keep it at 2.6rem...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 5 commits to psp-9907-legacy-payee asanchezr/PSP
  • PSP-9563 : Lease/Licence- Duplicate Files- Hide them in default (#4638) fb1e15f
  • CI: Bump version to v5.8.0-99.13 326e02c
  • PSP-9891 : L/L File - Ability to Add a Renewal Commencement Date Prio… (#4642) 7b310fb
  • CI: Bump version to v5.8.0-99.14 4c8ad03
  • Move legacy payee to PIMS_COMP_REQ_PAYEE table f418cc8

View on GitHub

asanchezr pushed 6 commits to dev asanchezr/PSP
  • PSP-9095 User is not able to delete the requisition (#4639) * Manually delete sub-entities CompReqPayees when deleti... dc526bf
  • CI: Bump version to v5.8.0-99.10 a0431c8
  • PSP-9890: FT-AUTO Task - Implement automated report and screenshots when test fails (#4641) * Changes on automation ... c6a3574
  • CI: Bump version to v5.8.0-99.11 186f648
  • Psp-9882 header corrections. (#4627) * header corrections - standardize usage and make sure font size and spacing co... a20df72
  • CI: Bump version to v5.8.0-99.12 215fe1f

View on GitHub

asanchezr pushed 9 commits to psp-9563 eddherrera/PSP
  • IS99 Scaffold (#4637) * Generated scaffold * Fixed compilation * Fixed compilation * Fixed test compilation 2508611
  • CI: Bump version to v5.8.0-99.9 9e68aea
  • PSP-9095 User is not able to delete the requisition (#4639) * Manually delete sub-entities CompReqPayees when deleti... dc526bf
  • CI: Bump version to v5.8.0-99.10 a0431c8
  • PSP-9890: FT-AUTO Task - Implement automated report and screenshots when test fails (#4641) * Changes on automation ... c6a3574
  • CI: Bump version to v5.8.0-99.11 186f648
  • Psp-9882 header corrections. (#4627) * header corrections - standardize usage and make sure font size and spacing co... a20df72
  • CI: Bump version to v5.8.0-99.12 215fe1f
  • Merge branch 'dev' into psp-9563 567bf18

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 1 commit to dev bcgov/PSP
  • Psp-9882 header corrections. (#4627) * header corrections - standardize usage and make sure font size and spacing co... a20df72

View on GitHub

asanchezr closed a pull request on bcgov/PSP
Psp-9882 header corrections.
Note that this is a "best-effort" attempt based on poor story definition.
asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
See comments

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
same comment about assigning "OrigExpiryDate" twice

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
`lease.OrigExpiryDate` was already given a value in line 694. Please remove one of them - no need to have this assignment duplicated

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
couple questions: * DocumentFormat.OpenXml.Vml.Spreadsheet seems like we wouldn't need that in tests... * First time I see "using static" - had to look it up. Not opposed to it but would like we ...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

Load more