Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

asanchezr

asanchezr pushed 9 commits to dev bcgov/PSP
  • Merge remote-tracking branch 'upstream/dev' into release/uat_is94 ff6ddb0
  • Merge pull request #4517 from asanchezr/release/uat_is94 UAT Release - IS93 and IS94 063fa1e
  • Merge remote-tracking branch 'upstream/dev' into uat-release-is95 1e70990
  • UAT Release IS-95 (#4542) * PSP-9565: Changes on automation test set to accomodate GHA (#4516) * data changes ... c3ef1f2
  • Merge branch 'test' into uat-release-is95 4e321d7
  • Merge pull request #4547 from asanchezr/uat-release-is95 Correction for git history on test branch d0de18c
  • PSP-9740 HOTFIX: User is not able to update the Acquisition Files (#4548) * PSP-9740: Fix faulty logic for Acquisiti... 6362ad3
  • Merge remote-tracking branch 'upstream/test' into backmerge_test_into_dev 4f9b1e0
  • Merge pull request #4551 from asanchezr/backmerge_test_into_dev Backmerge test into dev 6304a58

View on GitHub

asanchezr closed a pull request on bcgov/PSP
Backmerge test into dev
asanchezr opened a pull request on bcgov/PSP
Backmerge test into dev
asanchezr created a branch on asanchezr/PSP

backmerge_test_into_dev - Property Services Project

asanchezr pushed 1 commit to test asanchezr/PSP
  • PSP-9740 HOTFIX: User is not able to update the Acquisition Files (#4548) * PSP-9740: Fix faulty logic for Acquisiti... 6362ad3

View on GitHub

asanchezr pushed 17 commits to dev asanchezr/PSP
  • Changes for PSP-9710 and PSP-9313 834e092
  • Updated Snapshots and unit tests 8596065
  • Merging changes fd26b49
  • Updating AgreementView.ts 189f5e8
  • Adding IDs to delete buttons on periodColumns.tsx a1d974d
  • Merge branch 'dev' into PSP-9710 aaf3c43
  • PSP-9211 and PSP-9719 fixes a722faf
  • Fix of PR observations 4a93957
  • Merge branch 'PSP-9710' of https://github.com/stairaku/PSP into PSP-9710 0b97e70
  • Changing data-testId props e552cf1
  • Merge pull request #4541 from stairaku/PSP-9710 PSP-9710, PSP-9313: UI/UX Cleanup - Make icons consistent across PIMS 8aa0ab6
  • CI: Bump version to v5.7.0-96.4 7ad22ac
  • Merge branch 'bcgov:dev' into PSP-9211 d679429
  • Adding button element to fulfill unit tests 7f91f38
  • Merge branch 'PSP-9211' of https://github.com/stairaku/PSP into PSP-9211 8154368
  • Merge pull request #4546 from stairaku/PSP-9211 PSP-9211 and PSP-9719: UI/UX Clean up: Map Icons Replacement and PIM... 320668a
  • CI: Bump version to v5.7.0-96.5 8d5a0ba

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
I understand you don't touch those. But that is why I'm bringing it to your attention so you can coordinate with Devin and put those changes in 97. Otherwise we will loose it when this PR gets merged

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 1 commit to test bcgov/PSP
  • PSP-9740 HOTFIX: User is not able to update the Acquisition Files (#4548) * PSP-9740: Fix faulty logic for Acquisiti... 6362ad3

View on GitHub

asanchezr closed a pull request on bcgov/PSP
PSP-9740 HOTFIX: User is not able to update the Acquisition Files
The root cause was a previous attempt to fix a UTC date, which resulted in this error. Fixed by improving how we assign default "current date" in the backend. ![image](https://github.com/user-a...
asanchezr pushed 1 commit to psp-9740-hotfix asanchezr/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
@dfilteau please coordinate with @devinleighsmith regarding changes to the lease license role name. See his PR here: https://github.com/bcgov/PSP/pull/4545/files We would need to keep those c...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
nope because if you see the changes in the backend will generate the current date in the server timezone (DateTime.Today) - we have configured our API servers to run in PST timezone so we don't get...

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr pushed 1 commit to psp-9740-hotfix asanchezr/PSP

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
Approved but you will need to fix the frontend unit tests

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
Approved with comments

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
no sure whether we need this here?

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
thanks for making these!

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
**nit:** This component is generic so the styled container shouldn't be named "StyledCompensationContainer" - maybe just "StyledContainer". This is very minor of course

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
View button default title should not be "edit" - maybe "view" would be more suitable?

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review comment on a pull request on bcgov/PSP
default title for remove buttons should be "remove" - not "edit"

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP

View on GitHub

asanchezr created a review on a pull request on bcgov/PSP
Looks good but I wonder if the same changes should be added to the BUILD folder and to the corresponding PSP_PIMS_LATEST folder as well. Otherwise we risk loosing those changes when Doug creates ...

View on GitHub

Load more