Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mathrack opened a draft pull request on xcompact3d/Incompact3d
forces: compute the unsteady contribution using the momentum-rhs
The previous velocity fields are no longer used.
mathrack created a branch on xcompact3d/Incompact3d
update_force_unst - Current CPU version of our solver for the Navier-Stokes equations
mathrack created a review on a pull request on xcompact3d/Incompact3d
The new code is broken compared with the original.
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
Looks OK to me, I would only remove the commented out code.
mathrack pushed 1 commit to fix_nvhpc_wind_turbine xcompact3d/Incompact3d
- Use lowercase for the variable name 9b3829c
rfj82982 pushed 1 commit to fix_nvhpc_wind_turbine xcompact3d/Incompact3d
- Remove unused variable b606a4c
rfj82982 created a comment on a pull request on xcompact3d/Incompact3d
The modifications from @mathrack look go to me. Apologies i push without making sure that I had deleted all the trialled code.
mathrack pushed 1 commit to fix_nvhpc_wind_turbine xcompact3d/Incompact3d
- Remove comment in acl_source.f90 faa5fce
mathrack created a comment on a pull request on xcompact3d/Incompact3d
I have tried to fix the loop in https://github.com/xcompact3d/Incompact3d/pull/329/commits/83b0e941b6ac1ab36a583c8e5a43f243d35a4978
mathrack pushed 1 commit to fix_nvhpc_wind_turbine xcompact3d/Incompact3d
- Update acl_source.f90 83b0e94
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think it is best to simply remove the comment and keep the `if (...) cycle` statement
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
This is not needed if the `if (...) cycle` statement above is present
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The original condition was : `if (dist<10.0*epsilon) then` The new code is broken compared with the original.
mathrack created a review on a pull request on xcompact3d/Incompact3d
The new code is broken compared with the original.
mathrack created a review on a pull request on xcompact3d/Incompact3d
The new code is broken compared with the original.
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
Looks OK to me, I would only remove the commented out code.
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
Looks OK to me, I would only remove the commented out code.
rfj82982 opened a pull request on xcompact3d/Incompact3d
Fix Force loop for the wind turbine case
Fix the issue with the loop for computing the forces for the ACL module. The problem was particularly severe for the NVHPC compilers. Now the case with NVHPC is about 20 times faster. For GNU the f...