Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pangolingo created a comment on a pull request on thoughtbot/fishery
Thanks for this improvement! @rakeshpetit and I tried it out and we agree that it makes this type of Class parameter behavior possible without having to hack around TypeScript. We left a few com...
pangolingo created a comment on a pull request on thoughtbot/fishery
Let's add a README update talking about this change too. I think the `### Typechecking ` section would be a good place. > #### Typechecking params that are classes > > By default Fishery us...
rakeshpetit created a review comment on a pull request on thoughtbot/fishery
It would be good to add this expectation in both the tests where we verify the type of the value in the created object. ``` expect(user.createdAt).toBeInstanceOf(DateTime); ```
rakeshpetit created a review comment on a pull request on thoughtbot/fishery
It would be good to add a few more tests demonstrating how `DeepPartial` handles nested values. ``` type Company = { name: string; users: User[]; }; const companyFactory = Factory.def...
rakeshpetit created a review on a pull request on thoughtbot/fishery
LGTM! As long as the build passes.
rakeshpetit created a review comment on a pull request on thoughtbot/fishery
Do we have to mention this? What would happen if we did not add the `packageManager`?
pangolingo created a comment on an issue on thoughtbot/fishery
I don't know why Typescript requires you to narrow your type (`status: 'published' as const`) for the class extension but not the factory. They're both using the same `define` function internally. ...
pangolingo created a comment on an issue on thoughtbot/fishery
I have observed this behavior too. This is a Typescript bug/feature (I also am not sure which to call it). Here's some details: - [StackOverflow post explaining why Typescript lets this happen](ht...
pangolingo created a comment on an issue on thoughtbot/fishery
This is more of a JavaScript syntax issue than a problem with this library. You're free to use an explicit undefined check in your factory instead of destructuring assignment if that works better f...
pangolingo created a comment on a pull request on thoughtbot/fishery
I compared the built files (files in the `/dist` directory after this upgrade. There are few changes between the output of the new Rollup version vs the old one. They seem mostly syntax improvement...
pangolingo pushed 6 commits to di-rollup-upgrades thoughtbot/fishery
- Merge pull request #149 from thoughtbot/di-jest-ts-upgrades Upgraded Jest and Typescript to newer versions 88ae9ea
- Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changel... 1e074fc
- Merge pull request #152 from thoughtbot/dependabot/npm_and_yarn/braces-3.0.3 Bump braces from 3.0.2 to 3.0.3 da01331
- Bump micromatch from 4.0.4 to 4.0.8 Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8... 80e6388
- Merge pull request #153 from thoughtbot/dependabot/npm_and_yarn/micromatch-4.0.8 Bump micromatch from 4.0.4 to 4.0.8 511d39f
- Upgraded Rollup and its dependencies to the latest versions This required changing the config's file extension to `.... 4167a25
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
github-actions[bot] opened a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
github-actions[bot] created a branch on thoughtbot/fishery
github-actions/repository-maintenance-511d39f953412b43e787775e73f8bc9263f1b5f5 - A library for setting up JavaScript objects as test data
pangolingo pushed 2 commits to main thoughtbot/fishery
pangolingo closed a pull request on thoughtbot/fishery
Bump micromatch from 4.0.4 to 4.0.8
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/micromatch/micromatch/re...
dependabot[bot] pushed 3 commits to dependabot/npm_and_yarn/micromatch-4.0.8 thoughtbot/fishery
- Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changel... 1e074fc
- Merge pull request #152 from thoughtbot/dependabot/npm_and_yarn/braces-3.0.3 Bump braces from 3.0.2 to 3.0.3 da01331
- Bump micromatch from 4.0.4 to 4.0.8 Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8... 80e6388
github-actions[bot] opened a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
github-actions[bot] created a branch on thoughtbot/fishery
github-actions/repository-maintenance-da013319505452e923f3ce946f4eb60c8a6af83f - A library for setting up JavaScript objects as test data
pangolingo pushed 2 commits to main thoughtbot/fishery
pangolingo closed a pull request on thoughtbot/fishery
Bump braces from 3.0.2 to 3.0.3
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/micromatch/braces/commit/74b2db2938fad48a2ea54a9c...
dependabot[bot] opened a pull request on thoughtbot/fishery
Bump micromatch from 4.0.4 to 4.0.8
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/micromatch/micromatch/re...
dependabot[bot] created a branch on thoughtbot/fishery
dependabot/npm_and_yarn/micromatch-4.0.8 - A library for setting up JavaScript objects as test data
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
dependabot[bot] opened a pull request on thoughtbot/fishery
Bump braces from 3.0.2 to 3.0.3
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/micromatch/braces/commit/74b2db2938fad48a2ea54a9c...